Skip to content

ci: extend quality gates to *-maintenance branches - #240

Merged
whme merged 3 commits into
mainfrom
agent-task
May 23, 2026
Merged

whme merged 3 commits into
mainfrom
agent-task

Conversation

@whme

@whme whme commented May 23, 2026

Copy link
Copy Markdown
Owner

Releases are cut from *-maintenance branches (see
xtask/src/release.rs), so PRs landing there need the same CI
gates as PRs into main. Previously only pre-submit, post-submit,
and the news-fragment check ran for PRs/pushes targeting main,
leaving maintenance branches without gating.

With this change:

  • pre-submit.yml, post-submit.yml, and news-fragment-check.yml
    also trigger on *-maintenance.
  • news-fragment-check.yml diffs against origin/${{ github.base_ref }}
    instead of a hard-coded origin/main, so the fragment detection
    works correctly when the PR base is a maintenance branch.

deploy_github_pages.yml and dependabot-auto-merge.yml remain
main-only on purpose: the published docs/coverage site should
reflect main, and Dependabot only targets main. Note that
branch protection rules (required status checks) are configured
in the GitHub UI per branch and must be applied to
*-maintenance separately for these checks to be enforced.

Co-authored-by: Claude Opus 4.7 noreply@anthropic.com

Releases are cut from `*-maintenance` branches (see
`xtask/src/release.rs`), so PRs landing there need the same CI
gates as PRs into `main`. Previously only pre-submit, post-submit,
and the news-fragment check ran for PRs/pushes targeting `main`,
leaving maintenance branches without gating.

With this change:

- `pre-submit.yml`, `post-submit.yml`, and `news-fragment-check.yml`
  also trigger on `*-maintenance`.
- `news-fragment-check.yml` diffs against `origin/${{ github.base_ref }}`
  instead of a hard-coded `origin/main`, so the fragment detection
  works correctly when the PR base is a maintenance branch.

`deploy_github_pages.yml` and `dependabot-auto-merge.yml` remain
`main`-only on purpose: the published docs/coverage site should
reflect `main`, and Dependabot only targets `main`. Note that
branch protection rules (required status checks) are configured
in the GitHub UI per branch and must be applied to
`*-maintenance` separately for these checks to be enforced.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
@whme whme added the no-news-fragment-needed Indicates that this PR does not require a news fragment label May 23, 2026
@github-actions

github-actions Bot commented May 23, 2026 •

Copy link
Copy Markdown

🤖 News Fragment Check

✅ Success! This PR meets the news fragment requirements.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the project’s CI quality gates to apply not only to main, but also to *-maintenance branches (which are used for releases), and updates the news-fragment detection logic to diff against the PR’s actual base branch.

Changes:

  • Updated pre-submit.yml, post-submit.yml, and news-fragment-check.yml to trigger on both main and *-maintenance.
  • Updated news-fragment-check.yml to diff against origin/${{ github.base_ref }} instead of hard-coding origin/main.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/pre-submit.yml Expands PR branch triggers to include *-maintenance so pre-submit CI gates apply there too.
.github/workflows/post-submit.yml Expands push and pull_request_target triggers to include *-maintenance so post-submit CI gates apply there too.
.github/workflows/news-fragment-check.yml Expands triggers to *-maintenance and makes fragment detection base-branch aware via github.base_ref.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/post-submit.yml
@github-actions

github-actions Bot commented May 23, 2026 •

Copy link
Copy Markdown

🤖 Coverage Check
Total Coverage: 68.94%

Filename Stmts Miss Cover Missing
src\utils\config.rs 98 0 100.00%
src\utils\windows.rs 128 14 89.06% 308, 517-519, 1059-1060, 1082-1086, 1232-1237
src\cli.rs 314 57 81.85% 100-276
src\lib.rs 120 19 84.17% 257-265, 353-355, 373-382
xtask\src\release.rs 144 15 89.58% 27, 492-502, 505, 509, 615
xtask\src\inject_agent_token.rs 75 0 100.00%
xtask\src\social_preview.rs 101 3 97.03% 259, 262, 265
xtask\src\coverage.rs 55 3 94.55% 185, 199, 213
xtask\src\changelog.rs 29 0 100.00%
xtask\src\readme.rs 72 1 98.61% 123
xtask\src\typography.rs 91 1 98.90% 259
src\daemon\grid.rs 145 7 95.17% 184, 245-248, 261, 290, 296, 304
src\daemon\mod.rs 973 601 38.23% 383-385, 411-425, 524-528, 531, 592-965, 999-1000, 1006, 1008-1010, 1014-1024, 1062-1092, 1120, 1215, 1281-1314, 1398-1561, 1590-1591, 1621, 1629, 1652, 1671, 1681, 1688-1692, 1698, 1703-1715, 1737-1741, 1758-1759, 1765-1767, 1816, 1825-1829, 1848-1878, 1916-2139
src\daemon\workspace.rs 21 0 100.00%
src\protocol\serialization.rs 46 0 100.00%
src\protocol\deserialization.rs 79 2 97.47% 158, 168
src\client\mod.rs 381 169 55.64% 329-348, 394, 412, 420-425, 487, 491, 496-500, 523-698, 747-749, 752-761, 792-842
TOTAL 2872 892 68.94%

whme and others added 2 commits May 23, 2026 20:59
The post-submit workflow now also runs on `*-maintenance` branches, but
the header and inline documentation still described it as `main`-only.
Update the comments to reflect both trigger branches so future
maintainers are not misled.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
@whme
whme enabled auto-merge (squash) May 23, 2026 19:04
@github-actions

github-actions Bot commented May 23, 2026 •

Copy link
Copy Markdown

🤖 Diff Coverage Check

✅ Success!

Diff Coverage

Diff: origin/main...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

@whme
whme merged commit a633dad into main May 23, 2026
13 checks passed
@whme
whme deleted the agent-task branch May 23, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-news-fragment-needed Indicates that this PR does not require a news fragment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants