Repository navigation
ci: extend quality gates to *-maintenance branches - #240
Merged
Merged
Conversation
Releases are cut from `*-maintenance` branches (see
`xtask/src/release.rs`), so PRs landing there need the same CI
gates as PRs into `main`. Previously only pre-submit, post-submit,
and the news-fragment check ran for PRs/pushes targeting `main`,
leaving maintenance branches without gating.
With this change:
- `pre-submit.yml`, `post-submit.yml`, and `news-fragment-check.yml`
also trigger on `*-maintenance`.
- `news-fragment-check.yml` diffs against `origin/${{ github.base_ref }}`
instead of a hard-coded `origin/main`, so the fragment detection
works correctly when the PR base is a maintenance branch.
`deploy_github_pages.yml` and `dependabot-auto-merge.yml` remain
`main`-only on purpose: the published docs/coverage site should
reflect `main`, and Dependabot only targets `main`. Note that
branch protection rules (required status checks) are configured
in the GitHub UI per branch and must be applied to
`*-maintenance` separately for these checks to be enforced.
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
|
🤖 News Fragment Check ✅ Success! This PR meets the news fragment requirements. |
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the project’s CI quality gates to apply not only to main, but also to *-maintenance branches (which are used for releases), and updates the news-fragment detection logic to diff against the PR’s actual base branch.
Changes:
- Updated
pre-submit.yml,post-submit.yml, andnews-fragment-check.ymlto trigger on bothmainand*-maintenance. - Updated
news-fragment-check.ymlto diff againstorigin/${{ github.base_ref }}instead of hard-codingorigin/main.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/pre-submit.yml | Expands PR branch triggers to include *-maintenance so pre-submit CI gates apply there too. |
| .github/workflows/post-submit.yml | Expands push and pull_request_target triggers to include *-maintenance so post-submit CI gates apply there too. |
| .github/workflows/news-fragment-check.yml | Expands triggers to *-maintenance and makes fragment detection base-branch aware via github.base_ref. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🤖 Coverage Check
|
The post-submit workflow now also runs on `*-maintenance` branches, but the header and inline documentation still described it as `main`-only. Update the comments to reflect both trigger branches so future maintainers are not misled. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
whme
enabled auto-merge (squash)
May 23, 2026 19:04
|
🤖 Diff Coverage Check ✅ Success! Diff CoverageDiff: origin/main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases are cut from
*-maintenancebranches (seextask/src/release.rs), so PRs landing there need the same CIgates as PRs into
main. Previously only pre-submit, post-submit,and the news-fragment check ran for PRs/pushes targeting
main,leaving maintenance branches without gating.
With this change:
pre-submit.yml,post-submit.yml, andnews-fragment-check.ymlalso trigger on
*-maintenance.news-fragment-check.ymldiffs againstorigin/${{ github.base_ref }}instead of a hard-coded
origin/main, so the fragment detectionworks correctly when the PR base is a maintenance branch.
deploy_github_pages.ymlanddependabot-auto-merge.ymlremainmain-only on purpose: the published docs/coverage site shouldreflect
main, and Dependabot only targetsmain. Note thatbranch protection rules (required status checks) are configured
in the GitHub UI per branch and must be applied to
*-maintenanceseparately for these checks to be enforced.Co-authored-by: Claude Opus 4.7 noreply@anthropic.com