Add keyboard support for Tsishingini (tsw) - #860
Conversation
srish
left a comment
srish
left a comment
There was a problem hiding this comment.
@ToluAyodele Thanks Tolu for the PR! I've left some comments inline.
Besides these comments, there is one Git related issue. It looks like your git author meta data might be broken: “ToluAyo” <“tayodele-ctr@wikimedia.org”> - name and email are wrapped in curly quotes, so the email is invalid and won't attribute. Every of your other commit uses ToluAyodele <129562437+ToluAyodele@users.noreply.github.com>. Might need a git commit --amend --author=.....
| license: 'GPLv3', | ||
| version: '1.0', | ||
| patterns: [ | ||
| // Special letters |
There was a problem hiding this comment.
It looks like the source document lists several more letters that aren't typeable on a standard keyboard https://www.omniglot.com/charts/kambari.pdf. Is it possible to add those?
| name: 'ChiTumbuka tilde', | ||
| source: 'rules/tum/tum-tilde.js' | ||
| }, | ||
| 'tsw-tilde': { |
There was a problem hiding this comment.
Same sorting issue here too. Goes between tn-tilde and tum-tilde.
Added patterns for special letters 'c' and 'C' with their respective replacements.
2 participants
Downstream task: https://phabricator.wikimedia.org/T428848