Bootable JAR creation migration guide

[jfdenise]

No description provided.

[github-actions]

A preview of this PR is available at https://pr-916-wildfly-org.surge.sh

[rhusar]

@jfdenise Can you find/nominate someone to review?

[jfdenise]

@jmesnil would be a good candidate for this review.

[rhusar]

Suggested change

	NOTE: The `<feature-pack-location>` element as to be replaced by a nested location in the array of feature-packs.
	NOTE: The `<feature-pack-location>` element has to be replaced by a nested location in the array of feature-packs.

[rhusar]

@jmesnil would be a good candidate for this review.

Excellent, please have a look @jmesnil whenever you have a minute.

Just left a typo I spotted now.

[hpehl]

• @hpehl Manually tear down the preview once this PR is merged or closed.

[jfdenise]

@jmesnil , would you mind give a review? Thank-you.

[bstansberry]

@jfdenise A general comment is I see a number of places where "WildFly ... Plugin" should be "the WildFly ... Plugin" -- i.e. "the" is missing. Maybe in the title if you are trying to be a short as possible that's ok, but in normal text it reads as ungrammatical.

I'm too lazy to point out the specifics. ;)

[jfdenise]

@bstansberry and @rhusar, thank-you. I have made the suggestions.

[rhusar]

@jfdenise I don't have the capacity to assess this, but AI review found the following issues:

Wrong or misleading guidance

1. Root context is lost (line 374): Step 3 says the old plugin deployed at / by default, but the "After" configs in Examples 1, 4 and 5 leave out ROOT.war. A user who copies them gets the app at //, and existing URLs and health probes return 404.
2. run and dev goal mapping (line 339): the guide maps wildfly-jar:run → wildfly:run and wildfly-jar:dev → wildfly:dev. In 6.0.1, neither new goal has a bootable-JAR parameter, so they deploy to a regular server instead of running the bootable JAR.
3. CLI script settings (line 282):
   • is now a list, and the guide doesn't say so.
   • resolve-expressions defaults to false in the new plugin (confirmed). If the old plugin defaulted it to true (not checked), ${env.X} expressions in CLI scripts stop resolving after migration.
4. options (line 240): the guide calls the cloud feature-pack "identical" to , but child settings like and have no migration path and are silently dropped.
5. ROOT.war only fits WAR projects (line 65): for EAR or JAR packaging, the deployment gets the wrong extension and fails to deploy.

Missing from the guide
6. dev-watch and runtime arguments (line 318): the goal table leaves out wildfly-jar:dev-watch and the wildfly.bootable.arguments / wildfly.bootable.jvmArguments properties. The guide should point users to the server-args / java-opts parameters of the new plugin's start-jar goal.
7. Rename table is incomplete (line 284): for example, install-artifact-classifier → bootable-jar-install-artifact-classifier and display-cli-scripts-output → stdout aren't listed. The old names are ignored with at most a warning, so nothing tells the user why the build changed.

Do you want to address any of this?

[jfdenise]

@rhusar , thank-you. I addressed them

[rhusar]

Few more comments that all cause the migrated setup to fail.

[jfdenise]

@rhusar , thank-you. Fixed.

[rhusar]

All critical issues have been fixed, moving on with this.

[rhusar]

Thanks @jfdenise !