Skip to content

fix NAR n-step prediction across estimators - #244

Merged
wilsonrljr merged 1 commit into
mainfrom
issue_nar
Aug 8, 2026
Merged

wilsonrljr merged 1 commit into
mainfrom
issue_nar

Conversation

@wilsonrljr

Copy link
Copy Markdown
Owner
  • compute exact block horizons without internal padding
  • reuse shared NAR step-ahead logic in General NARX and NARXNN
  • validate step sizes and preserve fractional predictions for integer NAR data
  • cover partial blocks, bias modes, shared consumers, and Array API fallback

@wilsonrljr wilsonrljr self-assigned this Aug 8, 2026
@wilsonrljr wilsonrljr added the bug Something isn't working label Aug 8, 2026
@wilsonrljr
wilsonrljr merged commit 711167e into main Aug 8, 2026
7 of 8 checks passed
@wilsonrljr
wilsonrljr deleted the issue_nar branch August 8, 2026 22:24
@codacy-production

codacy-production Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 30 high

Alerts:
⚠ 30 issues (≤ 0 issues of at least minor severity)

Results:
30 new issues

Category Results
Security 30 high

View in Codacy

🟢 Metrics 42 complexity · -3 duplication

Metric Results
Complexity 42
Duplication -3

View in Codacy

🟢 Coverage 95.45% diff coverage · -0.02% coverage variation

Metric Results
Coverage variation ✅ -0.02% coverage variation (-1.00%)
Diff coverage ✅ 95.45% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5adc2e7) 5622 5553 98.77%
Head commit (f80646e) 5613 (-9) 5543 (-10) 98.75% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#244) 22 21 95.45%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant