Skip to content

feat: edit meeting [WPB-25677] - #5129

Open
saleniuk wants to merge 9 commits into
developfrom
feat/meeting-edit
Open

feat: edit meeting [WPB-25677]#5129
saleniuk wants to merge 9 commits into
developfrom
feat/meeting-edit

Conversation

@saleniuk

@saleniuk saleniuk commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25677


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Editing a meeting: fetching next occurrence to get data initially and executing the edit when user submits.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

In dev-debug app, open "meetings" tab, click "three dots" menu next to the upcoming meeting, click "edit" and try to update the meeting.

Attachments (Optional)

Screen_recording_20260803_155341.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.27119% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.19%. Comparing base (84ba688) to head (c548d48).
⚠️ Report is 2 commits behind head on develop.

⚠️ Current head c548d48 differs from pull request most recent head 150fba7

Please upload reports for the commit 150fba7 to get more accurate results.

Files with missing lines Patch % Lines
.../feature/meetings/ui/create/NewMeetingViewModel.kt 84.88% 5 Missing and 8 partials ⚠️
...id/feature/meetings/ui/MeetingsViewModelFactory.kt 0.00% 11 Missing ⚠️
...id/feature/meetings/ui/create/NewMeetingNavArgs.kt 83.33% 2 Missing ⚠️
...meetings/ui/options/MeetingOptionsMenuViewModel.kt 71.42% 1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (76.27%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5129      +/-   ##
===========================================
+ Coverage    50.16%   50.19%   +0.03%     
===========================================
  Files          666      666              
  Lines        24394    24461      +67     
  Branches      3777     3796      +19     
===========================================
+ Hits         12237    12279      +42     
- Misses       11039    11053      +14     
- Partials      1118     1129      +11     
Files with missing lines Coverage Δ
...e/android/feature/meetings/mapper/MeetingMapper.kt 73.80% <100.00%> (+0.63%) ⬆️
...tings/ui/options/MeetingOptionsModalSheetLayout.kt 0.00% <ø> (ø)
...id/feature/meetings/ui/create/NewMeetingNavArgs.kt 83.33% <83.33%> (-16.67%) ⬇️
...meetings/ui/options/MeetingOptionsMenuViewModel.kt 79.31% <71.42%> (+1.12%) ⬆️
...id/feature/meetings/ui/MeetingsViewModelFactory.kt 0.00% <0.00%> (ø)
.../feature/meetings/ui/create/NewMeetingViewModel.kt 83.83% <84.88%> (-2.38%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ba688...150fba7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Test Results

109 tests   109 ✅  8s ⏱️
 18 suites    0 💤
 18 files      0 ❌

Results for commit 5370964.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk
saleniuk requested a review from ohassine August 4, 2026 12:22
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants