Wire only meeting participant invites on schedule modal [WPB-25056] - #21643
Merged
Conversation
Use contact search with remote lookup and showAllProvidedUsers, drop edit prefill email placeholders, baseline invitation diffs on resolved emails only, and surface named ParticipantMissingEmailError messages via i18n.
thisisamir98
requested review from
arjita-mitra,
e-maad,
otto-the-bot,
screendriver and
zskhan
as code owners
June 24, 2026 14:30
thisisamir98
changed the title
thisisamir98
changed the title
M1 adds and removes schedule-meeting participants via ConversationRepository on the meeting's qualified_conversation, with metadata-only meetings API calls and no webapp invitation endpoint usage.
ConversationRepository is not registered in the tsyringe container, which caused edit meeting to throw at runtime.
screendriver
requested changes
Jun 29, 2026
Meetings now sync Wire participants via conversation membership only.
Replace useMeetingsList with a createMeetingStore factory and MeetingStoreProvider so list state lives at the meetings feature boundary.
Colocate safe* methods with their wrapped APIs, deprecate direct throws from meetings code paths, and add establishMeetingConversation for MLS shell setup without event injection.
Wire meeting submit through Task-based sync and the meeting store so create/update establishes MLS groups, syncs participants, and refreshes the list.
After a successful schedule or update, surface failedToAdd via an acknowledge dialog reusing existing i18n keys.
screendriver
reviewed
Jul 3, 2026
screendriver
reviewed
Jul 3, 2026
screendriver
reviewed
Jul 3, 2026
Establish MLS only on create and return partial add failures for the UI. On update, add new participants then remove unselected ones without attempting to establish broken conversations.
…eeting-participants
The previous wrapper around addUsers() could still resolve successfully when participants were not added. safeAddUsers now calls the MLS core service directly and returns partial failures in the Task value channel, matching establishMeetingConversation for the meeting update flow.
…eeting-participants
Apply nx format:write fixes so lint:other Prettier check passes in CI.
When meeting metadata is saved but participant sync fails, the submit hook now refreshes the list before showing the error so the UI stays in sync with the server.
LoadMeetingsListResult now includes hasLoadError on success. Update the empty-list test expectation so it matches the current return shape.
…eeting-participants
CI lint failed because the test file was not formatted according to project Prettier rules.
|
screendriver
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use contact search with remote lookup and showAllProvidedUsers, drop edit prefill email placeholders, baseline invitation diffs on resolved emails only, and surface named ParticipantMissingEmailError messages via i18n.