feat: add accessibility string for profile icon [WPB-21213]#21831
Open
e-maad wants to merge 3 commits into
Open
feat: add accessibility string for profile icon [WPB-21213]#21831e-maad wants to merge 3 commits into
e-maad wants to merge 3 commits into
Conversation
e-maad
requested review from
arjita-mitra,
ikotarac,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
July 13, 2026 20:15
|
screendriver
requested changes
Jul 14, 2026
screendriver
left a comment
screendriver
left a comment
Member
There was a problem hiding this comment.
Please add tests for the newly constructed accessible name. At minimum, cover the availability status, combined MLS and Proteus verification, and the EXPIRES_SOON translation. The current expired/expiring-soon mistake would have been caught by such a test.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add accessibility string for profile link