Use refresh event for WebApp updates [WPB-22420]#21838
Open
screendriver wants to merge 1 commit into
Open
Conversation
Use the lifecycle refresh event when the WebApp update banner reloads inside Wire Desktop, preserving the existing browser reload behavior.
screendriver
requested review from
arjita-mitra,
e-maad,
ikotarac,
otto-the-bot,
thisisamir98 and
zskhan
as code owners
July 14, 2026 08:04
screendriver
enabled auto-merge
July 14, 2026 08:04
|
zskhan
previously approved these changes
Jul 14, 2026
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When the “Update now” banner is used inside Wire Desktop, the WebApp currently publishes
WebAppEvents.LIFECYCLE.RESTART.Wire Desktop interprets this as a request to relaunch the Electron application. During that relaunch, the WebApp URL is reconstructed from the configured environment, so query parameters such as
enabled-featuresare lost.A WebApp update only requires the existing WebViews to be refreshed. It does not require the Electron application itself to restart.
Changes
This changes
App.refresh()to publishWebAppEvents.LIFECYCLE.REFRESHin desktop environments.The browser behavior remains unchanged and still reloads the current page directly.
Existing uses of
WebAppEvents.LIFECYCLE.RESTARTare intentionally unchanged because they represent operations that may require a real desktop application restart.Result
Wire Desktop can now distinguish between refreshing the WebApp and restarting the Electron application.
This allows the desktop client to reload the existing WebView while preserving its current URL, including startup feature-toggle query parameters.
See also wireapp/wire-desktop#9696