Make sure large buffers are on the heap with SMALL_STACK#10245
Open
Frauschi wants to merge 1 commit intowolfSSL:masterfrom
Open
Make sure large buffers are on the heap with SMALL_STACK#10245Frauschi wants to merge 1 commit intowolfSSL:masterfrom
Frauschi wants to merge 1 commit intowolfSSL:masterfrom
Conversation
|
Contributor
Author
|
Jenkins retest this please |
SparkiDev
requested changes
Apr 19, 2026
| long totalLen = 0; | ||
| char buf[512]; /* Should be more than enough for a single row */ | ||
| char* bufEnd = buf + sizeof(buf); | ||
| WC_DECLARE_VAR(buf, char, 512, NULL); /* enough for a single row */ |
Contributor
Author
There was a problem hiding this comment.
added LINE_BUFFER_SIZE define.
| mp_int* by = key->tmp.p1->z; | ||
| mp_int* prime = &key->params.prime; | ||
| unsigned char eb[128]; | ||
| WC_DECLARE_VAR(eb, unsigned char, 128, key->heap); |
Contributor
Author
There was a problem hiding this comment.
Added SAKKE_EB_BUF_SIZE define.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10245
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
Contributor
Author
|
Fixed the identified issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure buffers larger than around 100 bytes are allocated on the heap when
WOLFSSL_SMALL_STACKis defined.Follow-up for zd#21610, fixes zd#21642.