Open
Conversation
…ble NULL arg tests in hkdf_test() and srtpkdf_test().
…ULE_INIT code path (currently unused), add missing declaration for i.
examples/pem/pem.c: * improve error messages, * add wc_SetSeed_Cb() if WC_RNG_SEED_CB, and * add wolfCrypt_Init() and wolfCrypt_Cleanup(). scripts/pem.test: * fix exit code to unmask script failure, * add configured feature detection, * improve error messages and handling, * add configuration gating around subtests, and * comment out currently failing subtests.
douzzer
requested review from
JeremiahM37,
SparkiDev,
wolfSSL-Bot and
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10262
Scan targets checked: linuxkm-bugs, linuxkm-src
No new issues found in the changed files. ✅
|
scripts/pem.test: * add setup for WOLFSSL_NO_DER_TO_PEM, * exit early with skip code if executable dependencies are missing or WOLFSSL_NO_PEM or NO_CODING, and * add clean skip clauses to convert_to_pem(), compare_pem(), and pem_der_exp(), if WOLFSSL_NO_DER_TO_PEM.
douzzer
force-pushed
the
20260420-test-fixes
branch
from
9d70142 to
8b67392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfcrypt/test/test.c: add missing FIPS gating for backward-incompatibleNULLarg tests inhkdf_test()andsrtpkdf_test(). (fixes #10238 / 3175c33).linuxkm/module_hooks.c: inwolfssl_init()FIPS_OPTEST_FULL_RUN_AT_MODULE_INITcode path (currently unused), add missing declaration fori(fixes F-3026).fix
examples/pem/andscripts/pem.test:examples/pem/pem.c:wc_SetSeed_Cb()ifWC_RNG_SEED_CB, andwolfCrypt_Init()andwolfCrypt_Cleanup().scripts/pem.test:tested with