Reject CRLs with unrecognized critical entry extensions per RFC 5280 section 5.3#10274
Open
gasbytes wants to merge 1 commit intowolfSSL:masterfrom
Open
Reject CRLs with unrecognized critical entry extensions per RFC 5280 section 5.3#10274gasbytes wants to merge 1 commit intowolfSSL:masterfrom
gasbytes wants to merge 1 commit intowolfSSL:masterfrom
Conversation
|
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10274
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
gasbytes
force-pushed
the
crl-idp-extension-fix-follow-up
branch
from
daf5582 to
f485239
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reject CRLs with unrecognized critical entry extensions per RFC 5280 section 5.3.
This is a follow-up to #10239
Testing
./configure --enable-crl --enable-opensslextra --enable-debug &&
make -j8 &&
make check
The changes includes two tests covering the appropriate involved paths
The certs used in the tests are the same ones approved in #10239.
Checklist