Use built-in badge for homepage release badge - #278
Conversation
|
@Arteiimis is attempting to deploy a commit to the waruqi's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for mellow-creponne-9cce3d ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the raw release tag text in the HomeHeroInfo component with a VPBadge component and refactors the associated CSS to use flexbox and a brightness filter on hover. The review feedback highlights a potential layout issue where relative positioning units may cause inconsistent vertical alignment across different screen sizes and identifies an unused box-shadow transition property that should be removed for cleanliness.
| text-decoration: underline; | ||
| text-decoration-color: transparent; | ||
| text-underline-offset: 0.16em; | ||
| top: -0.6em; |
There was a problem hiding this comment.
The top offset is defined in em units relative to the inherited font size (which scales from 32px to 56px across breakpoints), but the VPBadge now has a fixed size (via the small class). This causes the badge's vertical position to shift inconsistently relative to its own height as the screen size changes. Consider using a fixed offset (e.g., in px) or setting a fixed font-size on this wrapper so the em offset remains proportional to the badge itself.
| .xmake-release-badge-chip { | ||
| margin-left: 0; | ||
| transform: none; | ||
| transition: filter 0.2s ease, box-shadow 0.2s ease; |
There was a problem hiding this comment.
The transition property includes box-shadow, but no box-shadow is defined or modified on hover for the .xmake-release-badge-chip. This is unnecessary code and should be cleaned up.
transition: filter 0.2s ease;
2 participants
Follow-up to #277.
The previous PR was merged before the final built-in Badge update was pushed. This PR rebases that last change onto current master.