Skip to content

feat(xfp): scaffold NSLS-II XFP (17-BM), the fleet's first dose-delivery beamline (X-ray footprinting, offline mass-spec readout), reverse-engineered#395

Merged
xmap merged 2 commits into
mainfrom
worktree-xfp-deployment
Jun 26, 2026

Conversation

@xmap

@xmap xmap commented Jun 26, 2026

Copy link
Copy Markdown
Owner

What

Reverse-engineers NSLS-II's XFP beamline (17-BM, X-ray Footprinting of Biological Materials, a Case Western Reserve University partner beamline) from the public bluesky profile collection (NSLS2/xfp-profile-collection). XFP does synchrotron X-ray footprinting: an intense white / pink beam generates hydroxyl radicals that footprint a protein or nucleic acid in solution; the structural readout is done offline by mass spectrometry.

Why XFP

It is the fleet's first dose-delivery beamline and the most structurally distinct deployment yet. Every other beamline CORA models is a measurement beamline (condition a beam, place a sample, record a detector signal). XFP has no scattering, area, or imaging detector at all. The experiment variable is the delivered radiolytic dose (exposure time x flux x attenuation); the run produces a footprinted sample plus a dose record, and the structural analysis is the offline-readout seam (mass spec, downstream and off the instrument). The novelty lands on the Method, the Subject, and the seam, not on device vocabulary.

What is modelled

14 devices, all real verified PVs, every value confirm, zero new families: the storage ring (loose StorageRing), the bendable white-beam front-end mirror (Mirror), the white-beam + ADC defining slits (Slit), the 8-position Al filter wheel that sets the dose rate (Filter), the personnel + timed dose shutters (Shutter), the DG535 delay generator that fires the millisecond Uniblitz fast shutter (TimingController, its opening-time is the dose time), the capillary-flow / high-throughput / HTFly sample stages (LinearStage), the sample-delivery pump (loose FlowController), the QuadEM flux monitor (FluxMonitor), and the Sydor beam-position monitor (loose BeamPositionMonitor). There is no monochromator in the footprinting path (white / pink beam; the only DCM is a separate XAS endstation, out of scope).

CORA-lens decisions

  • The dose-delivery chain (shutters + delay-generator timer + filter wheel + flux monitors) is modelled as devices CORA drives.
  • The fraction collector, the pure-Python 96-well plate addressing (no robot, no PV), and the offline mass spec are the sample-custody and offline-readout seam, not devices.
  • The sample-delivery pump reuses the loose FlowController family (i22 + 7-BM + LIX), making XFP its fourth consumer, past the rule-of-three LIX fired; the FlowController graduation stays a separate gated PR.
  • New pending Method x_ray_footprinting, the fleet's first dose-delivery Method.

Verification

  • Multi-lens adversarial verify (5 lenses + synthesis) against the real source: PV exactness, dose-delivery + no-detector headline, family reuse + fluidics/custody seam, CORA-lens + fabrication + hygiene, completeness + internal consistency. All 5 pass; zero must-fixes. The 14 PVs match source exactly, the "no detector / offline MS readout" headline is confirmed true (only ADBase as a QuadEM base class). 5 prose-fidelity nits applied (DG535 opening-time wording, PHD2000 pump role, custody-as-Procedure precedent).
  • tests/unit/deployments: 403 passed (XFP auto-enrolled; x_ray_footprinting registered in _PENDING_METHODS; FlowController n=4 in _PROMOTION_REVIEWED).
  • make docs-build --strict: clean.
  • Merged latest main (additive reconcile with the parallel-merged AMX beamline).

🤖 Generated with Claude Code

xmap and others added 2 commits June 26, 2026 13:14
… dose-delivery beamline (X-ray footprinting, offline mass-spec readout), reverse-engineered

Reverse-engineer NSLS-II's XFP beamline (17-BM, X-ray Footprinting of Biological
Materials, a Case Western Reserve University partner beamline) from the public
bluesky profile collection (NSLS2/xfp-profile-collection). XFP does synchrotron
X-ray footprinting: an intense white / pink beam generates hydroxyl radicals that
covalently modify a protein or nucleic acid in solution at solvent-accessible
sites; the structural readout is done offline by mass spectrometry.

Why XFP: it is the fleet's first DOSE-DELIVERY beamline and the most structurally
distinct deployment yet. Every other beamline CORA models is a measurement
beamline (condition a beam, place a sample, record a detector signal). XFP has NO
scattering, area, or imaging detector at all. The experiment variable is the
delivered radiolytic dose (exposure time x flux x attenuation); the run produces a
footprinted SAMPLE plus a DOSE RECORD, and the structural analysis is the
offline-readout seam (mass spec, downstream and off the instrument). The novelty
lands on the Method, the Subject, and the seam, not on device vocabulary.

What is modelled (14 devices, all real verified PVs, every value confirm, zero new
families): the storage ring (loose StorageRing), the bendable white-beam front-end
mirror (Mirror), the white-beam and ADC defining slits (Slit), the eight-position
Al filter wheel that sets the dose rate (Filter), the personnel and timed dose
shutters (Shutter), the DG535 delay generator that fires the millisecond Uniblitz
fast shutter (TimingController, its opening-time is the dose time), the
capillary-flow / high-throughput / HTFly sample stages (LinearStage), the
sample-delivery pump (loose FlowController), the QuadEM flux monitor (FluxMonitor),
and the Sydor beam-position monitor (loose BeamPositionMonitor). There is no
monochromator in the footprinting path (white / pink beam; the only DCM is a
separate XAS endstation, out of scope).

CORA-lens decisions: the dose-delivery chain (shutters + delay-generator timer +
filter wheel + flux monitors) is modelled as devices CORA drives; the fraction
collector, the pure-Python 96-well plate addressing (no robot, no PV), and the
offline mass spec are the sample-custody and offline-readout seam, not devices. The
sample-delivery pump REUSES the existing loose FlowController family (i22 + 7-BM +
LIX), making XFP its FOURTH consumer, past the rule-of-three LIX fired; the
FlowController graduation stays a separate gated PR. New pending Method
x_ray_footprinting, the fleet's first dose-delivery Method.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Reconcile the nsls2 beamlines list + practices, docs index table, and mkdocs nav
keep-both with the parallel-merged AMX (17-ID-1) deployment.
@xmap xmap enabled auto-merge (squash) June 26, 2026 10:23
@github-actions

Copy link
Copy Markdown

Coverage report

This PR does not seem to contain any modification to coverable code.

@xmap xmap merged commit 959187a into main Jun 26, 2026
16 checks passed
@xmap xmap deleted the worktree-xfp-deployment branch June 26, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant