feat(isr): scaffold NSLS-II ISR (4-ID) deployment, deliberately partial (optics + Eiger; mission devices deferred), reverse-engineered#399
Merged
Conversation
…al (optics + Eiger; diffractometer / in-situ / resonant axis deferred), reverse-engineered Reverse-engineer NSLS-II's ISR beamline (4-ID, In Situ and Resonant hard X-ray studies) from the public bluesky profile collection (NSLS2/isr-profile-collection). ISR's mission is resonant scattering near absorption edges, surface / interface diffraction (crystal truncation rods), and in-situ sample environments. Why partial: the public profile collection is an early / commissioning, optics-and-detectors-first scaffold. It binds the front-end slit, the in-vacuum undulator gap (read-only), the DCM, the focusing and harmonic-rejection mirrors, the attenuator bank, the Eiger 1M, the diagnostic screen cameras, and only two end-station axes (th, zeta, under the Dif:ISD diffractometer IOC). The devices that make ISR's name (the multi-circle DIFFRACTOMETER, the IN-SITU sample environment, a wired RESONANT energy axis, and POLARIZATION analysis) are ABSENT or stubbed in the source (the flux-monitor electrometers are commented out, the energy axis is a non-functional stub), so the scaffold models what is PV-bound and routes the four mission-critical gaps to open questions (DIFF-1 / INSITU-1 / RESONANT-1), the same discipline as the i20-1 (EDE) partial. What is modelled (11 devices, all real verified PVs, every value confirm, zero new families): the storage ring (loose StorageRing), the IVU undulator gap (InsertionDevice), the DCM (Monochromator), the bendable focusing pair + the harmonic-rejection mirror (Mirror), the front-end slit (Slit), the four-foil attenuator bank (Filter), the single bound sample rotation (RotaryStage, NOT a multi-circle Goniometer, which is absent), the Eiger 1M + diagnostic screen cameras (Camera), and the motorized beam-position-monitor stage (loose BeamPositionMonitor). Zero new families, zero new Method slugs: the resonant / surface-diffraction science reuses the existing pending resonant_scattering (4-ID / CSX) and diffraction (4-ID / 8-ID) Methods, doubly deferred because the diffractometer they run on is not yet in source. Adversarial single-agent verify (ultracode off): the partial thesis confirmed true in source (all four mission-device absences real), family reuse / hygiene / consistency clean, 9/11 PVs exact; fixed two PV-leaf errors it caught (the attenuator Cmd:In-Cmd -> Cmd:Opn-Cmd, the front-end slit }Mtr -> the virtual center leaf). Note: dir `isr` does not collide with the existing APS `4-id` (POLAR) deployment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Coverage report
This PR does not seem to contain any modification to coverable code. |
xmap
added a commit
that referenced
this pull request
Jun 26, 2026
Resolve the append-only conflicts (NSLS-II beamline list, mkdocs nav, deployments index row, the FlowController/BeamPositionMonitor promotion-review notes) against the current main, which has advanced to ISR (#399). Reconcile CDI against i13-1 (#398, merged after CDI was opened): i13-1 is the fleet's first coherent diffractive imaging and coined the pending ptychography Method. CDI no longer claims "first"; it is the second coherent-imaging deployment and the first at NSLS-II / first full source-to-detector one, reinforcing i13-1's pending ptychography Method (ptychography reuses it; forward / Bragg CDI are its single-shot variants, not separately coined). No Practice recorded (CHX discipline). Gate: 424 deployment tests pass, mkdocs --strict clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
xmap
added a commit
that referenced
this pull request
Jun 26, 2026
Resolve the NSLS-II beamline list, mkdocs nav, deployments index, and practices-comment conflicts against current main (now at ISR #399 + CDI #396); PDF appends after CDI. No content reconciliation needed: PDF is high-energy total scattering, unrelated to the coherent-imaging cohort. Gate: 431 deployment tests pass, mkdocs --strict clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverse-engineers NSLS-II's ISR beamline (4-ID, In Situ and Resonant hard X-ray studies) from the public bluesky profile collection (NSLS2/isr-profile-collection). ISR's mission is resonant scattering near absorption edges, surface / interface diffraction (crystal truncation rods), and in-situ sample environments.
Why partial
The public profile collection is an early / commissioning, optics-and-detectors-first scaffold. It binds the front-end slit, the IVU undulator gap (read-only), the DCM, the focusing + harmonic-rejection mirrors, the attenuator bank, the Eiger 1M, the diagnostic screen cameras, and only two end-station axes (
th,zeta, under theDif:ISDIOC). The devices that make ISR's name, the multi-circle diffractometer, the in-situ sample environment, a wired resonant energy axis, and polarization analysis, are absent or stubbed in source (the flux-monitor electrometers are even commented out, and the energy axis is a non-functional stub). So the scaffold models what is PV-bound and routes the four mission-critical gaps to open questions (DIFF-1/INSITU-1/RESONANT-1), the same discipline as the i20-1 (EDE) partial.What is modelled
11 devices, all real verified PVs, every value
confirm, zero new families, zero new Method slugs: the storage ring (loose StorageRing), the IVU undulator gap (InsertionDevice), the DCM (Monochromator), the bendable focusing pair + harmonic-rejection mirror (Mirror), the front-end slit (Slit), the four-foil attenuator bank (Filter), the single bound sample rotation (RotaryStage, not a multi-circle Goniometer, which is absent), the Eiger 1M + diagnostic screen cameras (Camera), and the motorized beam-position-monitor stage (loose BeamPositionMonitor). The resonant / surface-diffraction science reuses the existing pendingresonant_scattering(4-ID / CSX) anddiffraction(4-ID / 8-ID) Methods, doubly deferred because the diffractometer they run on is not yet in source.Verification
Cmd:In-Cmd->Cmd:Opn-Cmd; front-end slit}Mtr-> the virtual-center leaf, since it's a center/gap pseudo-positioner).isrdirectory does not collide with the existing APS4-id(POLAR) deployment (different facility).tests/unit/deployments: 417 passed.make docs-build --strict: clean.🤖 Generated with Claude Code