[Misc] Fix various mechanical SonarQube issues in the rendering modules

[claude]

Jira URL

None — this is a [Misc] SonarQube cleanup commit.

Changes

Description

Fixes 9 open SonarCloud issues in xwiki-rendering, all purely mechanical and
behaviour-preserving.

Rule	#	Change
java:S5361	8	replaceAll() → replace() where the pattern is a plain literal (the accent-transliteration table in XWikiSerializer2)
java:S1066	1	merge collapsible nested if in ParserUtils

Open issues for this project on SonarCloud

Clarifications

• Only calls whose first argument reduces to a literal were converted: the single-character
  "\uXXXX" patterns, and replaceAll("\\.", "") which becomes replace(".", "") — the escaped
  regex dot is the literal dot. None of the replacement strings contain $ or \, which are the
  only characters whose meaning differs between replaceAll and replace. The remaining
  replaceAll calls in that method use real character classes and were left alone.
• The ParserUtils merge folds if (block instanceof MacroBlock macro) { if (!macro.isInline()) }
  into a single condition; the inner if was the sole statement of the outer one and there is no
  else.

Screenshots & Video

No UI change.

Executed Tests

mvn install -Plegacy,quality of xwiki-rendering-api and xwiki-rendering-wikimodel —
BUILD SUCCESS, 562 tests, 0 failures, 0 errors.

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  • None — master only.

Related

Part of the same SonarQube sweep:

• [Misc] Fix various mechanical SonarQube issues in the commons modules xwiki-commons#1862
• [Misc] Fix various mechanical SonarQube issues in the platform modules xwiki-platform#6043

---

Generated by Claude Code