[Misc] Move the legacy module Revapi ignores to the root pom - #394
Merged
Conversation
* Revapi ignores for xwiki-rendering are declared in the root pom, so move the MacroDescriptorAspect#aroundGetDefaultCategory ignore there from the xwiki-rendering-legacy-transformation-macro pom. * The revapi-maven-plugin declaration in that module only existed to hold that ignore, so it's removed and the module now inherits the root configuration. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira URL
N/A —
[Misc]change (build configuration cleanup, no functional impact).Changes
Description
pom.xml, which iswhere xwiki-rendering keeps its Revapi ignores.
The ignore concerns
MacroDescriptorAspect#aroundGetDefaultCategory(
java.annotation.attributeValueChanged) and was living inxwiki-rendering-legacy/xwiki-rendering-legacy-transformations/xwiki-rendering-legacy-transformation-macro/pom.xml.revapi-maven-plugindeclaration from that module: the ignore was its only content, sothe module now simply inherits the root configuration.
Clarifications
combine.children="append"attribute (and its accompanying comment) is dropped along the waysince it was only needed to append to the root pom ignores from a child pom.
there was to move.
<code>in the root pommakes
xwiki-rendering-legacy-transformation-macrofail with the expectedjava.annotation.attributeValueChangederror onaroundGetDefaultCategory, and restoring it makesthe build pass again. So the ignore is really picked up from the root pom by the legacy module.
Screenshots & Video
N/A — no UI change.
Executed Tests
mvn install -B -ntp -Plegacy,snapshot -pl xwiki-rendering-legacy/xwiki-rendering-legacy-transformations/xwiki-rendering-legacy-transformation-macro→ BUILD SUCCESS,
revapi:checkruns and passes, 10 tests pass.mvn install -B -ntp -Psnapshot,legacy -DskipTests(full reactor, to validate the inherited rootRevapi configuration on every module) → BUILD SUCCESS.
Expected merging strategy
🤖 Generated with Claude Code