#143: tokenizer: stop scan at comment-end: fix identifier parse - #144
Merged
Merged
Conversation
philgebhardt
force-pushed
the
tokenize-identifier
branch
from
September 6, 2026 02:02
1cf4459 to
a12c79b
Compare
Collaborator
|
@philgebhardt : Thanks for the PR. Looks good. Can you please sign the commit using |
…arse Fixes identifier parsing for ASN.1 identifiers that are immediately followed by a comment, with no separating whitespace. [Example][1] [1]: https://github.com/EFForg/rayhunter/blob/86529a6a70048d4f0033e2f38fdd8a8b37d48802/telcom-parser/specs/LPP-PDU-Definitions.asn#L2091 Signed-off-by: Phil Gebhardt <gebhardt.phil@gmail.com>
philgebhardt
force-pushed
the
tokenize-identifier
branch
from
September 7, 2026 14:20
a12c79b to
e8491ce
Compare
Contributor
Author
|
Thanks @gabhijit! I've properly signed the commit. |
1 task done
Collaborator
Sorry! this totally fell through the cracks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#143
Fixes identifier parsing for ASN.1 identifiers that are immediately followed by a comment, with no separating whitespace.
Example