fix: add depth limit and input validation to json parser - #69
Merged
Merged
Conversation
- cap the nesting level of object/array at maxParseDepth - treat an empty value as null instead of indexing into it - validate the type of the reserved node id key - report a duplicated node id as an error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更
maxParseDepth，超出返回ErrNestedTooDeep___jnid_的值类型，非整数返回ErrInvalidNodeIdErrDuplicateNodeId测试
新增
parse_test.go：TestParseNoPanic覆盖截断、空值等畸形输入组合TestParseInvalidNodeId覆盖___jnid_取值类型与重复节点 IDTestParseNestingDepth验证深度边界（限制内可正常解析，超出报错）go test ./...全量通过。