Skip to content

Fix CI & More resilient GNU tar checks on macoS - #59

Closed
cupcakearmy wants to merge 2 commits into
zen-browser:mainfrom
cupcakearmy:fix/gnu-tar-detection
Closed

cupcakearmy wants to merge 2 commits into
zen-browser:mainfrom
cupcakearmy:fix/gnu-tar-detection

Conversation

@cupcakearmy

Copy link
Copy Markdown
Contributor

Hi there :)
I was trying to get started with building zen browser. I have gnu tar installed not via brew, so that my normal tar command is already the gnu version. surfer on macos expected a hardcoded command gtar (installed via brew).
This PR

  • Fixes install issues with deprecated dependencies (chekced the actions, they were failing since may)
  • Runs --version on tar and gtar to check if it is actually gnu tar before failing.

…inary

On macOS, check if tar or gtar is genuinely GNU tar by running
`<executable> --version` and looking for '(GNU tar)', instead of
only checking if the 'gtar' binary exists. This allows the system
'tar' to be used if it's already GNU (e.g. on Nix/macports).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant