Repository navigation
Fix CI & More resilient GNU tar checks on macoS - #59
Closed
cupcakearmy wants to merge 2 commits into
Closed
cupcakearmy wants to merge 2 commits into
cupcakearmy wants to merge 2 commits into
Conversation
…inary On macOS, check if tar or gtar is genuinely GNU tar by running `<executable> --version` and looking for '(GNU tar)', instead of only checking if the 'gtar' binary exists. This allows the system 'tar' to be used if it's already GNU (e.g. on Nix/macports).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there :)
I was trying to get started with building zen browser. I have gnu
tarinstalled not via brew, so that my normaltarcommand is already the gnu version. surfer on macos expected a hardcoded commandgtar(installed via brew).This PR
--versionontarandgtarto check if it is actually gnu tar before failing.