Conversation
kartben
marked this pull request as ready for review
September 17, 2026 09:06
kartben
requested review from
Martinhoff-maker,
asmellby,
jerome-pouiller and
jhedberg
as code owners
September 17, 2026 09:06
Zephyr's stdout is unbuffered under both libcs: minimal libc's zephyr_fputc() calls _stdout_hook() directly, and picolibc sets up __stdout as FDEV_SETUP_STREAM() with a null buffer. So the flush does nothing, while minimal libc declares no fflush() and the implicit declaration breaks the build with -Werror. print_sl_ipv6_address() does not flush either. Upstream-status: Pending Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org> Assisted-by: Claude:opus-5
kartben
force-pushed
the
siwx917-drop-noop-fflush
branch
from
September 17, 2026 09:07
1463399 to
ab8384b
Compare
kartben
added a commit
to kartben/zephyr
that referenced
this pull request
Sep 17, 2026
Pull in zephyrproject-rtos/hal_silabs#192, which drops a no-op fflush() that minimal libc cannot declare. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org> Assisted-by: Claude:opus-5
kartben
added a commit
to kartben/zephyr
that referenced
this pull request
Sep 18, 2026
Pull in zephyrproject-rtos/hal_silabs#192, which drops a no-op fflush() that minimal libc cannot declare. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org> Assisted-by: Claude:opus-5
jerome-pouiller
left a comment
jerome-pouiller
left a comment
Collaborator
There was a problem hiding this comment.
We try to automate the integration of the version of wiseconnect/sisdk. So, could you start the title with "wiseconnect: Patch ".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
print_sl_ipv4_address()callsfflush(stdout), but Zephyr's stdout is unbuffered under both libcs — minimal libc'szephyr_fputc()goes straight to_stdout_hook(), and picolibc sets up__stdoutasFDEV_SETUP_STREAM(picolibc_put, NULL, NULL, 0), a null buffer. The flush does nothing.More importantly, minimal libc declares no
fflush()and has no implementation, so the implicit declaration is fatal under-Werror. This breakscpp.main.minimalon siwx917_ek2708a, siwx917_rb4342a, siwx917_dk2605a and siwx917_rb4338a (the scenario setsCONFIG_PM=y, which selectsSILABS_SIWX91X_NWPand pullssl_utility.cinto the build).print_sl_ipv6_address()right below does not flush, so the file is already inconsistent :)