Raise http_request rx buffer to 5120 for GitHub's CSP header#94
Conversation
The redirect on release-asset downloads carries a ~3.6 KB Content-Security-Policy header line; esp_http_client requires each header line to fit the rx buffer, so 2048 still failed with "HTTP_CLIENT: Out of buffer" (confirmed on hardware running 26.7.8.6; the new manifest guard correctly refused to install, so no downgrade). Version: 26.7.8.7 🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThis PR increases the ChangesESPHome config updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Version: 26.7.8.7
What does this implement/fix?
Follow-up to #93: the 2048-byte rx buffer is still too small. The redirect on GitHub release-asset downloads carries a ~3.6 KB Content-Security-Policy header line, and
esp_http_clientrequires each header line to fit the rx buffer - so beta manifest fetches kept failing withHTTP_CLIENT: Out of buffereven on 26.7.8.6 (confirmed on hardware; measuredContent-Security-Policyat 3585 bytes today). Raised to 5120 for headroom.Silver lining from the same hardware test: #93's manifest guard worked - after the failed fetch it refused to install, so no wrong-channel downgrade and no lost WiFi this time.
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
🤖 Generated with Claude Code
Summary by CodeRabbit