Skip to content

[AutoPR Azure.ResourceManager.Relationships]-generated-from-SDK Generation - .NET-6862960 - #63238

Open
azure-sdk-automation[bot] wants to merge 2 commits into
mainfrom
sdkauto/Azure.ResourceManager.Relationships-6862960
Open

azure-sdk-automation[bot] wants to merge 2 commits into
mainfrom
sdkauto/Azure.ResourceManager.Relationships-6862960

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Configurations: 'specification/relationships/resource-manager/Microsoft.Relationships/Relationships/tspconfig.yaml', and CommitSHA: '85e949e122626f546750f7ce795e278f0523c1d9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6862960 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=35597 Submitted by: meghanagupta@microsoft.com

Copilot AI balanced review requested due to automatic review settings September 21, 2026 15:46
@azure-sdk-automation azure-sdk-automation Bot added the auto-sdk-build-fix SDK PR with failed build; eligible for automated Generator Agent build-fix repair label Sep 21, 2026
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Sep 21, 2026
@github-actions github-actions Bot added the Mgmt This issue is related to a management-plane library. label Sep 21, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

SDK Build Repair completed successfully!

Generated by SDK Build Repair for #63238

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Existing compiled tests and samples still reference the removed model API and obsolete relationship contract.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 High severity · 4 Medium severity · 2 Low severity

Open (7)
What changed in this PR

Regenerates the Relationships management SDK from the 2026-08-01 TypeSpec specification.

Changes:

  • Updates the specification location and API version.
  • Adds Contains listings, parent-scoped paging, and service-group dependency operations.
  • Regenerates models, serialization, extensions, and public API listings.
File Description
sdk/​relationships/​Azure.ResourceManager.Relationships/​tsp-location.yaml Updates the TypeSpec source and commit.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​ServiceGroupMemberRelationshipResource.cs Updates the default API version.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​ServiceGroupMemberRelationshipData.Serialization.cs Uses the regenerated properties model.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​ServiceGroupMemberRelationshipData.cs Updates the public properties type.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​ServiceGroupMemberRelationshipCollection.cs Adds pageable list operations.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​RestOperations/​ServiceGroupMemberRelationshipsRestOperations.cs Adds parent-list requests.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​RestOperations/​DependencyOfRelationshipsRestOperations.cs Adds parent-list requests.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​RestOperations/​DependencyOfRelationshipsByServiceGroupRestOperations.cs Adds service-group REST operations.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​RestOperations/​ContainsRelationshipsRestOperations.cs Adds Contains list requests.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​ProviderConstants.cs Adds provider namespace lookup.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Models/​ServiceGroupMemberRelationshipPropertiesV2.Serialization.cs Regenerates model serialization.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Models/​ServiceGroupMemberRelationshipPropertiesV2.cs Adds the revised properties contract.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Models/​ServiceGroupMemberRelationshipListResult.Serialization.cs Adds list-result serialization.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Models/​ServiceGroupMemberRelationshipListResult.cs Adds the list-result model.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Models/​DependencyOfRelationshipProperties.Serialization.cs Updates optional-property handling.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Models/​DependencyOfRelationshipListResult.Serialization.cs Adds dependency-list serialization.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Models/​DependencyOfRelationshipListResult.cs Adds the dependency-list model.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Models/​ContainsRelationshipProperties.Serialization.cs Adds Contains properties serialization.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Models/​ContainsRelationshipProperties.cs Adds Contains relationship properties.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Models/​ContainsRelationshipListResult.Serialization.cs Adds Contains-list serialization.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Models/​ContainsRelationshipListResult.cs Adds the Contains-list model.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Models/​ContainsRelationship.Serialization.cs Adds Contains resource serialization.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Models/​ContainsRelationship.cs Adds the Contains resource model.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Models/​AzureResourceManagerRelationshipsContext.cs Registers new generated models.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​LongRunningOperation/​DependencyOfRelationshipsByServiceGroupResourceOperationSource.cs Adds service-group operation conversion.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Internal/​PageableWrapper.cs Adds synchronous page conversion.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Internal/​AsyncPageableWrapper.cs Adds asynchronous page conversion.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Extensions/​RelationshipsExtensions.cs Exposes new relationship operations.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Extensions/​MockableRelationshipsSubscriptionResource.cs Adds subscription Contains listings.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Extensions/​MockableRelationshipsResourceGroupResource.cs Adds resource-group Contains listings.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​Extensions/​MockableRelationshipsArmClient.cs Adds service-group dependency accessors.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​DependencyOfRelationshipsByServiceGroupResource.Serialization.cs Adds resource serialization support.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​DependencyOfRelationshipsByServiceGroupResource.cs Adds service-group dependency operations.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​DependencyOfRelationshipsByServiceGroupCollection.cs Adds the scoped resource collection.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​DependencyOfRelationshipResource.cs Updates the default API version.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​DependencyOfRelationshipCollection.cs Adds pageable parent listings.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​CollectionResults/​ServiceGroupMemberRelationshipsGetByParentCollectionResultOfT.cs Implements synchronous member paging.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​CollectionResults/​ServiceGroupMemberRelationshipsGetByParentAsyncCollectionResultOfT.cs Implements asynchronous member paging.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​CollectionResults/​DependencyOfRelationshipsGetByParentCollectionResultOfT.cs Implements synchronous dependency paging.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​CollectionResults/​DependencyOfRelationshipsGetByParentAsyncCollectionResultOfT.cs Implements asynchronous dependency paging.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​CollectionResults/​DependencyOfRelationshipsByServiceGroupGetAllCollectionResultOfT.cs Implements scoped synchronous paging.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​CollectionResults/​DependencyOfRelationshipsByServiceGroupGetAllAsyncCollectionResultOfT.cs Implements scoped asynchronous paging.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​CollectionResults/​ContainsRelationshipsGetBySubscriptionCollectionResultOfT.cs Implements subscription paging.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​CollectionResults/​ContainsRelationshipsGetBySubscriptionAsyncCollectionResultOfT.cs Implements asynchronous subscription paging.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​CollectionResults/​ContainsRelationshipsGetByResourceGroupCollectionResultOfT.cs Implements resource-group paging.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​CollectionResults/​ContainsRelationshipsGetByResourceGroupAsyncCollectionResultOfT.cs Implements asynchronous resource-group paging.
sdk/​relationships/​Azure.ResourceManager.Relationships/​src/​Generated/​ArmRelationshipsModelFactory.cs Updates factories for regenerated models.
sdk/​relationships/​Azure.ResourceManager.Relationships/​metadata.json Records API version 2026-08-01.
sdk/​relationships/​Azure.ResourceManager.Relationships/​api/​Azure.ResourceManager.Relationships.net8.0.cs Updates the .NET 8 public API listing.

Comment on lines +16 to +24
public partial class ServiceGroupMemberRelationshipPropertiesV2
{
/// <summary> Keeps track of any properties unknown to the library. </summary>
private protected readonly IDictionary<string, BinaryData> _additionalBinaryDataProperties;

/// <summary> Initializes a new instance of <see cref="ServiceGroupMemberRelationshipPropertiesV2"/>. </summary>
/// <param name="sourceId"> The relationship source resource id. Must be a service group. </param>
/// <exception cref="ArgumentNullException"> <paramref name="sourceId"/> is null. </exception>
public ServiceGroupMemberRelationshipPropertiesV2(ResourceIdentifier sourceId)
/// </summary>
/// <param name="cancellationToken"> The cancellation token to use. </param>
/// <returns> A collection of <see cref="DependencyOfRelationshipResource"/> that may take multiple service requests to iterate over. </returns>
public virtual AsyncPageable<DependencyOfRelationshipResource> GetAllAsync(CancellationToken cancellationToken = default)
Comment on lines +80 to +83
public virtual async Task<ArmOperation<DependencyOfRelationshipsByServiceGroupResource>> CreateOrUpdateAsync(WaitUntil waitUntil, string name, DependencyOfRelationshipData data, CancellationToken cancellationToken = default)
{
Argument.AssertNotNullOrEmpty(name, nameof(name));
Argument.AssertNotNull(data, nameof(data));
/// <param name="cancellationToken"> The cancellation token to use. </param>
/// <exception cref="ArgumentNullException"> <paramref name="resourceGroupResource"/> is null. </exception>
/// <returns> A collection of <see cref="ContainsRelationship"/> that may take multiple service requests to iterate over. </returns>
public static AsyncPageable<ContainsRelationship> GetByResourceGroupAsync(this ResourceGroupResource resourceGroupResource, string filter = default, CancellationToken cancellationToken = default)
/// </summary>
/// <param name="cancellationToken"> The cancellation token to use. </param>
/// <returns> A collection of <see cref="ServiceGroupMemberRelationshipResource"/> that may take multiple service requests to iterate over. </returns>
public virtual AsyncPageable<ServiceGroupMemberRelationshipResource> GetAllAsync(CancellationToken cancellationToken = default)
/// If you have a <see cref="ResourceIdentifier"/> you can construct a <see cref="DependencyOfRelationshipsByServiceGroupResource"/> from an instance of <see cref="ArmClient"/> using the GetResource method.
/// Otherwise you can get one from its parent resource <see cref="ArmResource"/> using the GetDependencyOfRelationshipsByServiceGroups method.
/// </summary>
public partial class DependencyOfRelationshipsByServiceGroupResource : ArmResource
namespace Azure.ResourceManager.Relationships.Models
{
/// <summary> ServiceGroupMember relationship properties. </summary>
public partial class ServiceGroupMemberRelationshipPropertiesV2
@github-actions

Copy link
Copy Markdown

SDK Build Repair - Already green (no repair needed) ✅

Summary

Package sdk/relationships/Azure.ResourceManager.Relationships
Final build status ✅ Green (no changes needed)
Iterations used 0 of 3
Engine azsdk tsp client customized-update --edit-scope CustomCode

Invariants Confirmed

  • No spec inputs modified (client.tsp, tspconfig.yaml, TypeSpec sources)
  • Pinned commit in tsp-location.yaml unchanged
  • No .github/, eng/, pipeline, or package-metadata files touched
  • No changes needed - nothing committed
Telemetry (machine-readable)
{"schema_version":"v1","run_id":"gha-35621214581-1","repo":"Azure/azure-sdk-for-net","pr":63238,"head_sha":"84fa6fc15ae66b2856930c8c0746acee51dc96df","eligible":true,"status":"skipped_already_green","repaired_at":null}

--generated by Copilot

Generated by SDK Build Repair for #63238 · copilot · auto · 126.7 AIC · ⌖ 7.18 AIC · ⊞ 12.8K ·
Comment /repair-build to run again

@github-actions

Copy link
Copy Markdown

🔍 CI Failure Analysis for PR #63238

Summary

Check Status
net - pullrequest (Azure DevOps, build 6863004) ❌ Failed
Build Analyze PRBatch ❌ Failed
Build Test * (all frameworks: net8.0, net9.0, net10.0, net462 — Windows/macOS/Ubuntu) ❌ Failed
Build Build PRBatch ✅ Success
Other scaffolding/compliance/SDL jobs ✅ Success

Root cause: compile errors in generated test code (all Build & Test jobs)

Every Build & Test (netX.0) job across all OS/framework combinations fails identically with C# compile errors in the test project Azure.ResourceManager.Relationships:

tests/Samples/Sample_ServiceGroupMemberRelationshipResource.cs(95,34): error CS0246:
The type or namespace name 'ServiceGroupMemberRelationshipProperties' could not be found
(are you missing a using directive or an assembly reference?)

tests/Samples/Sample_ServiceGroupMemberRelationshipCollection.cs(39,34): error CS0246:
The type or namespace name 'ServiceGroupMemberRelationshipProperties' could not be found

tests/Scenario/ServiceGroupMemberRelationshipResourceTests.cs(67,59): error CS0117:
'ArmRelationshipsModelFactory' does not contain a definition for 'ServiceGroupMemberRelationshipProperties'

tests/Scenario/ServiceGroupMemberRelationshipCollectionTests.cs(65,59) / (203,59) / (229,59): error CS0117:
'ArmRelationshipsModelFactory' does not contain a definition for 'ServiceGroupMemberRelationshipProperties'

This is a hard compilation failure, confirmed identically across net8.0, net9.0, net10.0, and net462 on Windows, macOS, and Ubuntu runners — this is not flaky/transient infrastructure noise.

Diagnosis: The generated sample/test files reference a type ServiceGroupMemberRelationshipProperties and expect ArmRelationshipsModelFactory to expose a matching factory method, but neither exists in the generated model surface for this package. This points to a mismatch between the TypeSpec-generated models and the generated samples/tests — either:

  • The ServiceGroupMemberRelationship model's properties type was renamed/removed in codegen but the sample/test generator emitted references to the old name, or
  • The corresponding model factory method for ServiceGroupMemberRelationshipProperties was not (re)generated in ArmRelationshipsModelFactory.cs.

Suggested fix

  1. Regenerate the Azure.ResourceManager.Relationships package from the current tsp-location.yaml commit (azsdk_package_generate_code / Generate.ps1) to ensure the generated samples/tests, models, and ArmRelationshipsModelFactory are all in sync.
  2. After regeneration, confirm the actual (current) name of the properties type backing ServiceGroupMemberRelationship (it may have been renamed during codegen) and verify ArmRelationshipsModelFactory exposes a matching factory method for it.
  3. Rebuild locally to confirm the compile errors are resolved:
    dotnet test eng/service.proj /p:ServiceDirectory=relationships --filter TestCategory!=Live
  4. Since Build Analyze PRBatch also failed (umbrella check covering codegen verification, API export, snippets, spelling, CPM), re-run it after regeneration to confirm no additional drift (e.g., API surface / CHANGELOG / snippet mismatches) remains.

Quick fix command

cd eng/packages/http-client-csharp && npm install
./eng/scripts/Generate.ps1

Then verify with:

dotnet build eng/service.proj /p:ServiceDirectory=relationships
dotnet test eng/service.proj /p:ServiceDirectory=relationships --filter TestCategory!=Live

Analyzed by Azure .NET Management SDK PR Review: https://github.com/Azure/azure-sdk-for-net/actions/runs/35624493426

@github-actions

Copy link
Copy Markdown

🔍 CI Failure Analysis for PR #63238

Check Status
net - pullrequest (all frameworks/OS: Windows/Ubuntu/MacOS × net8.0/9.0/10.0/net462) ❌ Failed
Build Analyze PRBatch, Build Build PRBatch, CPM/spelling/link/compliance checks ✅ Passed

Root cause: missing/stale test recordings for Azure.ResourceManager.Relationships

All Test * jobs failed with the same error across every target framework (net8.0, net9.0, net10.0, net462) and every OS. Example from Build & Test (net10.0) on macOS (build 6865804):

Failed CreateOrUpdate [184 ms]
Error Message:
 Azure.Core.TestFramework.TestRecordingMismatchException : If this is a new recording, make sure you have pushed the recordings to the assets repository. For instructions, see: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core.TestFramework/README.md#recording

Unable to find a record for the request PUT (management.azure.com/redacted)

This exact TestRecordingMismatchException pattern repeats 22 times in this single job's log (affecting tests such as CreateOrUpdate, CreateOrUpdate_OnKeyVaultResource, CreateOrUpdate_OnSubscription, Exists, Get, etc. in ServiceGroupMemberRelationshipCollectionTests and related scenario test classes under sdk/relationships/Azure.ResourceManager.Relationships/tests/Scenario/), and the same failure signature is present in every other Test * job (Windows2022, Ubuntu2404, MacOS × NET80/90/100/462, PackageRef/ProjectRef, Debug/Release). Category: Test recording mismatch.

Fix

The recorded session files in assets.json for sdk/relationships/Azure.ResourceManager.Relationships are out of date or missing relative to the requests the current test scenarios make (e.g., new/changed PUT calls). To resolve:

  1. Regenerate/re-record the tests locally in Record playback mode against a live (or updated) service, following Azure.Core.TestFramework recording instructions.
  2. Push the updated recordings to the assets repository:
    cd sdk/relationships/Azure.ResourceManager.Relationships
    ./eng/common/scripts/Update-AssetsJson.ps1 # or the standard `test-proxy push` workflow to publish new recordings
  3. Update assets.json in this package to point at the new recording tag/commit produced by the push.
  4. Re-run dotnet test eng/service.proj /p:ServiceDirectory=relationships --filter TestCategory!=Live locally to confirm the recordings match before pushing.

This is a data/generation issue (stale recordings tied to updated generated client behavior), not a compilation or ApiCompat problem — no error CS#### or MembersMustExist findings appear in the logs.

Analyzed by Azure .NET Management SDK PR Review: https://github.com/Azure/azure-sdk-for-net/actions/runs/35684335628

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. auto-sdk-build-fix SDK PR with failed build; eligible for automated Generator Agent build-fix repair Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants