Code to review Raimondi#3
Conversation
Dictionary created in a new module for the Dictionary demo Created Serializable interface Created Resource interface Created skeleton of a basic SMSResrouce
Created SMSNetDictionary class
Added Basic Unit Tests for Dictionary
…way to scan the dictionary)
Demo crash fix: app crash on start Created basic test for network usage
Added basic Network implementation (missing of some functions) Re-added Permission Requests
…to develop-rete
… if no peer is online (instead of null) Fixed ListView on simulator display Started updates on net control
…t in the dictionary) ConcatAll method added Some specifics addition
…to develop-rete
Thanks to enums now requests are 1 char long instead of many Implemented Net update notification: when 2 nets join they get both sides notified about the new people on the net
…to develop-rete
BugFix: special characters getting added to the net
BugFix: 2 SMSPeers with the same number now return true on .equals() BugFix: 2 SMSPeers with the same number now return the same hashCode() BugFix: 2 SMSPeers with the same number added to the same hashMap are now considered the same SMSPeer BugFix: updateNet skipping the first input number to add to the dictionary BugFix: concatAll now concatenates arrays if one of them is null; if both are null it returns null Improved concatAll specifics Added Test cases for these bugs
…sing Object instead of String. Consequent methods and classes adaptation.
SMSCore_Tests cleanup and fix
SMSCore_Tests cleanup and fix Added permissions in smslibrary Manifest
…to develop-rete
Lightly improved code comments on NetworkConnection
…to develop-rete
Implemented some methods to get network info (ex. if the network is empty and how many peers are online) Implemented some methods to add peers to the network BugFix: fixed nullPointerException during Net creation if myPeer was passed as null Improved code specifics Improved functions visibility
Implemented inviteToJoin method Made some methods more robust by adding checks Implemented sendPing method
Implemented (and tested)removePeer functions (input SMSPeer, SMSPeer[] and String) Improved specifics on some methods Improved code on some methods added regions to separate code blocks improved functions/classes visibility
|
Really good code, good overall formattation with correct use of spaces and alignements.
I have no other suggestions, really good work, keep coding like this! |
SerializableObject class created All SMSNetworkDictionary methods adaptation
There was a problem hiding this comment.
Hello sig. Raimondi,
I have reviewed your code.
The code is readable and the formatting is nice and respects the camelCase convention, maybe some other comment could have helped to read better the code.
Operations within the method are few and elemental so that it easy to understand and to change it later, good.
In my opinion, you could be more descriptive in the specifications, obviously being careful not to overdo it, mostly in the class SMSNetDictionary on @param and @return description.
I didn't see hardwiring and that it is excellent.
For the Test, you should test also the SMSNetDictionarySupport class.
All in all the code is not bad at all, and it presents several opportunities to improve.
| * @return Array containing all the elements of param's arrays; null if both arrays are null, | ||
| * the other array if only one is null | ||
| */ | ||
| protected static SMSResource[] concatAll(SMSResource[] array1, SMSResource[] array2) { |
There was a problem hiding this comment.
I'd have changed the name of this method to concatArrays
5 participants
Classes to review: WebDictionary -> Key, SMSKey, SMSNetDictionary, SMSNetDictionarySupport, Test