Skip to content

Code to review Raimondi #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EdoardoRaimondi wants to merge 43 commits into
base: code-review
Choose a base branch
from
Open

Code to review Raimondi #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
d26ebea
Solved warning
matteocarnelos Nov 6, 2019
cae65b2
Layout and demo skeleton added (missing dictionary calls)
EdoardoRaimondi Nov 8, 2019
5985ae6
Dictionary basic interface created
Cogno-Marco Nov 9, 2019
05799bd
implemented SMSResource skeleton (for testing usage)
Cogno-Marco Nov 9, 2019
a1fda13
Added Myself as author of my implementations
Cogno-Marco Nov 9, 2019
3d3bc70
4 of 6 methods implemented in SMSNetDictionary, authors name modifica…
EdoardoRaimondi Nov 10, 2019
aa412b4
All methods implementation, comments addition (need to find a better …
EdoardoRaimondi Nov 10, 2019
ec267e8
Testing adaptation (there are two still missing)
EdoardoRaimondi Nov 10, 2019
f9af2e8
Demo Activity improved UI
Cogno-Marco Nov 10, 2019
4adeb6f
Total testing adaptation
EdoardoRaimondi Nov 10, 2019
6707883
Network Demo:
Cogno-Marco Nov 10, 2019
753c608
Merge branch 'develop-rete' of https://github.com/EIS0/SMS_Library in…
EdoardoRaimondi Nov 10, 2019
32f19a8
Dynamic array size creation (doubleArraySize method created)
EdoardoRaimondi Nov 11, 2019
6c3f242
getAvailablePeers() from NetworkDictionary now returns an empty array…
Cogno-Marco Nov 11, 2019
51b8416
Add method improved (now u can add resources of a peer already presen…
EdoardoRaimondi Nov 11, 2019
304c21f
Merge branch 'develop-rete' of https://github.com/EIS0/SMS_Library in…
EdoardoRaimondi Nov 11, 2019
22c3746
Testing the new add method
EdoardoRaimondi Nov 11, 2019
3fc6254
Improved net code using enums
Cogno-Marco Nov 11, 2019
3fe7b86
Merge branch 'develop-rete' of https://github.com/EIS0/SMS_Library in…
Cogno-Marco Nov 11, 2019
c36da60
BugFix: multiple equal phone numbers getting added to the net
Cogno-Marco Nov 11, 2019
985c386
BugFix: Wrong simulator phone number
Cogno-Marco Nov 12, 2019
d2de50b
BugFix: SMSPeer not seeing valid numbers
Cogno-Marco Nov 12, 2019
3845c60
Covered 100% of SMSMessage
Cogno-Marco Nov 12, 2019
5dced85
Added ability to remove and update SMSPeers from the SMSNet
Cogno-Marco Nov 13, 2019
f8d0e02
Add a support class to SMSNetDictionary to let it do only what it has…
EdoardoRaimondi Nov 13, 2019
456a85e
SMSNet test increased
EdoardoRaimondi Nov 13, 2019
4757d3e
Add user exit management
EdoardoRaimondi Nov 13, 2019
1611df5
Structure refactor: SMSKey class creation, arguments generalization u…
EdoardoRaimondi Nov 14, 2019
777f4b3
Testing adaptation
EdoardoRaimondi Nov 14, 2019
628ced7
Fixed Basic Netowork class errors
Cogno-Marco Nov 15, 2019
4faecef
Fixed app crash in NetworkConnection
Cogno-Marco Nov 15, 2019
2bd1cf6
Fixed app crash in NetworkConnection
Cogno-Marco Nov 15, 2019
14426cf
SMSKey hashCode management. Test fixed
EdoardoRaimondi Nov 15, 2019
de6d7d1
Merge branch 'develop-rete' of https://github.com/EIS0/SMS_Library in…
EdoardoRaimondi Nov 15, 2019
8023135
Added a couple of tests for SMSHandler
Cogno-Marco Nov 15, 2019
6bc6a59
Merge branch 'develop-rete' of https://github.com/EIS0/SMS_Library in…
Cogno-Marco Nov 15, 2019
46799ea
Moved old tests to the right location
Cogno-Marco Nov 15, 2019
4ed523b
Added tests to NetworkConnection
Cogno-Marco Nov 15, 2019
c1b1714
Code cleaning
EdoardoRaimondi Nov 16, 2019
756a47f
Improved code style
Cogno-Marco Nov 16, 2019
d23f0a2
Moved enum and NetListener into proper classes
Cogno-Marco Nov 17, 2019
a974800
Code for the review
EdoardoRaimondi Nov 17, 2019
bc019b2
Using code test directed method:
EdoardoRaimondi Nov 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .idea/gradle.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions .idea/misc.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ dependencies {
implementation 'androidx.appcompat:appcompat:1.1.0'
implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
implementation 'com.google.android.material:material:1.0.0'
implementation 'androidx.preference:preference:1.1.0-alpha05'
implementation 'androidx.preference:preference:1.1.0'
testImplementation 'junit:junit:4.12'
androidTestImplementation 'androidx.test.ext:junit:1.1.1'
androidTestImplementation 'com.android.support.test:rules:1.0.2'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
compile project(path: ':smslibrary')
implementation project(path: ':smslibrary')
compile project(path: ':webdictionary')
}
44 changes: 0 additions & 44 deletions app/src/androidTest/java/com/eis0/library_demo/ExampleInstrumentedTest.java
View file
Open in desktop

This file was deleted.

Empty file removed app/src/androidTest/java/com/eis0/library_demo/SMSHandler_Tests.java
View file
Open in desktop
Empty file.
10 changes: 1 addition & 9 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,7 @@
android:supportsRtl="true"
android:theme="@style/AppTheme">
<activity
android:name="com.eis0.library_demo.SettingsActivity"
android:label="@string/title_activity_settings"
android:parentActivityName="com.eis0.library_demo.DemoActivity">
<meta-data
android:name="android.support.PARENT_ACTIVITY"
android:value="com.eis0.library_demo.DemoActivity" />
</activity>
<activity
android:name="com.eis0.library_demo.DemoActivity"
android:name=".NetworkDemo"
android:label="@string/app_name"
android:theme="@style/AppTheme">
<intent-filter>
Expand Down
257 changes: 0 additions & 257 deletions app/src/main/java/com/eis0/library_demo/DemoActivity.java
View file
Open in desktop

This file was deleted.

Loading