feat: updated zhCN & zhTW related#384
Closed
Yarnus wants to merge 1 commit into
Closed
Conversation
Owner
|
i had already accepted someone elses translations so i had to manually merge this as there were too many conflicts, but I added it. thank you!! if i missed anything please rebase and submit a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First of all, thank you for building EllesmereUI. I really appreciate how clean, minimal, and lightweight this addon is. I have been recommending it to players around me because it offers a polished UI experience without feeling bloated.
Some of those players are not equally comfortable with English, so I drafted this PR to improve Simplified Chinese and Traditional Chinese support. I hope this can make the addon easier to use for more Chinese-speaking players.
Changes
Notes
The existing locale engine already supports zhCN and zhTW, so this PR focuses only on improving translation coverage and the visible language labels.