Repository navigation
fix(app-bridge-app): send the handshake to window.parent instead of window.top - #1697
Open
SedukhinaPolina wants to merge 1 commit into
Open
SedukhinaPolina wants to merge 1 commit into
SedukhinaPolina wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 15680f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps couldn't connect when their host is itself in an iframe, like the new Finder embedded in a customer page: the handshake went to
window.top(the customer page) instead of the frame that embedded the app. Now it goes towindow.parent. When the app frame sits directly in the web app, the two are the same window, so nothing changes there.🧪 How to test
I tested it with a local build linked into the QR code app, opened from the Finder embedded in a standalone page. The app connects and uploads.