Skip to content

fix(app-bridge-app): send the handshake to window.parent instead of window.top #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SedukhinaPolina wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(app-bridge-app): send the handshake to window.parent instead of window.top #1697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/gentle-frames-answer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@frontify/app-bridge-app": patch
---

fix: send the connection handshake to the embedding window instead of the top window

Apps now connect when the platform hosting them is itself embedded in an iframe, such as the asset chooser inside another page. The handshake also no longer reaches the top-level page.
2 changes: 1 addition & 1 deletion packages/app-bridge-app/src/utilities/notify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import { type NotifyData, type NotifyOptions } from '../types/Notify.ts';

export function notify<T>(topic: string, token: string, data?: NotifyData<T>, options?: NotifyOptions): void {
const parentWindow = window.top;
const parentWindow = window.parent;
parentWindow?.postMessage(
{
topic,
Expand Down
Loading