Repository navigation
Conversation
🦋 Changeset detectedLatest commit: d2afa45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for fondue-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Table/utils.tsbuilt its list of interactive element classes (HTMLButtonElement,HTMLAnchorElement,HTMLInputElement) at module load. Those globals do not exist in Node, so importing@frontify/fondue-componentsduring server rendering or in a Node test throwsReferenceError: HTMLButtonElement is not defined, even when the Table is never used.The list is now read inside
shouldIgnoreRowClick, when a row click is checked. Behavior in the browser is unchanged.Verification
Table/__tests__/utils.node.spec.tsruns in the Node environment, the way thescripts/buildManifesttests already do. It fails with theReferenceErroronmainand passes with this change.@frontify/fondue-componentspatch.