Skip to content

fix(Table): import the components package in Node #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jcosta33 wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −2
Draft

fix(Table): import the components package in Node #2884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4ed081
fix(Table): read DOM element classes at call time so the package impo…
jcosta33 Oct 9, 2026
d2afa45
test(Table): import the Table utils in Node
jcosta33 Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/table-utils-node-import.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@frontify/fondue-components": patch
---

fix(Table): read the DOM element classes when a row click is checked, so the package imports in Node
13 changes: 13 additions & 0 deletions packages/components/src/components/Table/__tests__/utils.node.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/* (c) Copyright Frontify Ltd., all rights reserved. */

// @vitest-environment node

import { describe, expect, it } from 'vitest';

import { shouldIgnoreRowClick } from '../utils';

describe('Table utils without a DOM', () => {
it('loads in Node and ignores no row click without an event', () => {
expect(shouldIgnoreRowClick()).toBe(false);
});
});
8 changes: 6 additions & 2 deletions packages/components/src/components/Table/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ export function handleKeyDown(event: KeyboardEvent<HTMLTableElement>) {
}
}

const INTERACTIVE_ELEMENTS_LIST = [HTMLButtonElement, HTMLAnchorElement, HTMLInputElement];
const INTERACTIVE_ROLES_LIST = ['button', 'link'];

export function shouldIgnoreRowClick(event?: MouseEvent): boolean {
Expand All @@ -48,7 +47,12 @@ export function shouldIgnoreRowClick(event?: MouseEvent): boolean {
}

while (element && !(element instanceof HTMLTableRowElement)) {
if (INTERACTIVE_ELEMENTS_LIST.some((interactiveElement) => element instanceof interactiveElement)) {
// Read at call time, since the DOM classes do not exist when the module loads in Node.
if (
[HTMLButtonElement, HTMLAnchorElement, HTMLInputElement].some(
(interactiveElement) => element instanceof interactiveElement,
)
) {
return true;
}

Expand Down
Loading