fix(security): raise the aiohttp floor past the known advisories - #166
Merged
Conversation
`requirements.txt` allowed `aiohttp>=3.14.1`, which resolves happily to 3.14.1 or 3.14.2 — both affected by advisories the sidecar was already pinned away from: * GHSA-cq5v-8q36-5273 (high) — out-of-bounds heap read in the C HTTP response parser on malformed chunked responses; fixed in 3.14.3 * GHSA-mfx4-hv73-q22v — request smuggling via WebSocket upgrade; fixed in 3.14.2 * GHSA-mq44-7p77-q5h7 — WebSocket client accepting compressed frames without negotiated permessage-deflate; fixed in 3.14.2 `desktop/sidecar-requirements.{in,lock}` moved to 3.14.3 in 6923382, but the top-level floor was left where it was, so a fresh install resolving to the lower bound still landed on a vulnerable build. All three declarations now agree on 3.14.3, which is also the current release. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Zongwei9888
force-pushed
the
fix/aiohttp-floor
branch
from
August 7, 2026 06:41
c0de1dc to
d0ce827
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
requirements.txtallowedaiohttp>=3.14.1. That floor resolves happily to 3.14.1 or 3.14.2 — both affected by advisories the sidecar was already pinned away from:desktop/sidecar-requirements.{in,lock}moved to 3.14.3 in6923382, but the top-level floor was left behind — so a freshpip installresolving to the lower bound still landed on a vulnerable build. All three declarations now agree on 3.14.3, which is also the current release on PyPI.On the open Dependabot alerts
The three aiohttp alerts on this repo are stale, not outstanding work. They were opened at 08-04 08:08 UTC;
6923382pinned the sidecar to 3.14.3 at 09:04 UTC the same day, andmainhas carried 3.14.3 in both.inand.lockever since. Dependabot has not rescanned. They can be dismissed as fixed once this lands.The fourth alert —
glib 0.18.5indesktop/src-tauri/Cargo.lock, wanting ≥ 0.20.0 — is not addressed here.glibis a shared transitive dependency of twelve gtk-rs crates (gtk,gdk,webkit2gtk,cairo-rs,pango,gio, …), so moving it means a gtk-rs 0.18 → 0.20 migration and, in turn, Tauri itself. The advisory is anIteratorunsoundness rather than an exploitable path, so it seems reasonable to wait for the upstream bump.Testing
Verified
3.14.3exists on PyPI (it is the latest release) before setting the floor to it.pre-commitclean, includingrequirements-txt-fixer.CI has not run: GitHub Actions is in a
major_outageat time of writing, so every workflow on the repo is failing atSet up jobwithFailed to resolve action download info. Error: Service Unavailable. This needs a green run before merge — it is a one-line dependency change, but that is exactly the kind that should be seen installing cleanly.