Fix dpnp.tensor.expm1 handling of complex(+-0, 0) #2926
Open
vlad-perevezentsev wants to merge 3 commits into
Open
Fix dpnp.tensor.expm1 handling of complex(+-0, 0) #2926vlad-perevezentsev wants to merge 3 commits into
dpnp.tensor.expm1 handling of complex(+-0, 0) #2926vlad-perevezentsev wants to merge 3 commits into
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2926/index.html |
antonwolfy
reviewed
May 19, 2026
| Y = dpt.asnumpy(dpt.expm1(X)) | ||
| assert_allclose(Y, res, atol=tol, rtol=tol) | ||
|
|
||
| # assert_allclose treats +0 == -0 |
Contributor
There was a problem hiding this comment.
do we need to validate the sign in other cases also when imag=0.0 ?
Collaborator
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev0=py313h509198e_43 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to fix issue #2878 where
dpnp.tensor.expm1(complex(-0.0, 0.0))returned-0.0 + 0.0jon CPU instead of0.0 + 0.0jas required by the Array API specificationThe fix adds an explicit special-case branch for
complex(±0, 0)inexpm1.hppso CPU and GPU behavior are now consistent and compliant with the specification.Also
test_expm1_special_casestest was extended to covercomplex(-0.0, 0.0)