Skip to content

Fix dpnp.tensor.expm1 handling of complex(+-0, 0) #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vlad-perevezentsev wants to merge 3 commits into
base: master
Choose a base branch
from
+15 −1
Open

Fix dpnp.tensor.expm1 handling of complex(+-0, 0) #2926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
753692f
Fix complex expm1 for zero input
vlad-perevezentsev May 19, 2026
ea3320b
Extend test_expm1_special_cases to add -0 case
vlad-perevezentsev May 19, 2026
b8926d9
Update changelog
vlad-perevezentsev May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ This release is compatible with NumPy 2.4.5.
* Fixed `conda build` command syntax in GitHub workflows and documentation to use `conda-build` [#2888](https://github.com/IntelPython/dpnp/pull/2888)
* Fixed incorrect `dpnp.tensor.acosh` result for `complex(±0, NaN)` special case to match the Python Array API specification [#2914](https://github.com/IntelPython/dpnp/pull/2914)
* Fixed fork PR documentation workflow failures by implementing conditional publishing strategy: upstream PRs publish to GitHub Pages with comment, fork PRs upload artifacts [#2910](https://github.com/IntelPython/dpnp/pull/2910)
* Fixed incorrect `dpnp.tensor.expm1` result for `complex(±0, 0)` special case on CPU to match the Python Array API specification [#2926](https://github.com/IntelPython/dpnp/pull/2926)

### Security

Expand Down
4 changes: 4 additions & 0 deletions dpnp/tensor/libtensor/include/kernels/elementwise_functions/expm1.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,10 @@ struct Expm1Functor
}
}

if (x == realT(0) && y == realT(0)) {
return resT{realT(0), y};
}

// x, y finite numbers
const realT cosY_val = sycl::cos(y);
const realT sinY_val = (y == 0) ? y : sycl::sin(y);
Expand Down
11 changes: 10 additions & 1 deletion dpnp/tests/tensor/elementwise/test_expm1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ def test_expm1_special_cases():
num_finite = 1.0
vals = [
complex(0.0, 0.0),
complex(-0.0, 0.0),
complex(num_finite, dpt.inf),
complex(num_finite, dpt.nan),
complex(dpt.inf, 0.0),
Expand All @@ -165,6 +166,7 @@ def test_expm1_special_cases():
c_nan = complex(np.nan, np.nan)
res = np.asarray(
[
complex(0.0, 0.0),
complex(0.0, 0.0),
c_nan,
c_nan,
Expand All @@ -184,4 +186,11 @@ def test_expm1_special_cases():

tol = dpt.finfo(X.dtype).resolution
with np.errstate(invalid="ignore"):
assert_allclose(dpt.asnumpy(dpt.expm1(X)), res, atol=tol, rtol=tol)
Y = dpt.asnumpy(dpt.expm1(X))
assert_allclose(Y, res, atol=tol, rtol=tol)

# assert_allclose treats +0 == -0
Copy link
Copy Markdown
Contributor

@antonwolfy antonwolfy May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to validate the sign in other cases also when imag=0.0 ?

# verify sign bits for zero cases
for i in (0, 1):
assert not np.signbit(Y[i].real)
assert not np.signbit(Y[i].imag)
Loading