Repository navigation
ci: require the live suites in each platform check - #12970
Merged
Merged
Conversation
cv
enabled auto-merge (squash)
October 10, 2026 20:27
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-12970.docs.buildwithfern.com/nemoclaw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure
Since #12962,
Live / DockerandLive / Kindrun inside each Linux platform's reusable workflow withcontinue-on-error. A live failure never failsTest / PLATFORM, but each gate still waits for the platform's whole workflow, live jobs included. Required checks therefore wait for the live suites without depending on their result.In run 38070042632, measured from when its jobs started, every check that decides the gates finished by 674 s. Linux AMD64
Live / Dockerfinished at 1,077 s, and the gates at 1,080 s.Decision
Remove
continue-on-errorfrom both live jobs, so a live failure fails its platform'sTest / PLATFORMcheck, as a lifecycle failure does. When a change cannot affect the live suites, each live job skips its remaining steps and passes, as before. Check names are unchanged.The suites have been reliable enough to require. Since #12962, Linux Docker and Kind ran 19 times each and passed every run that wasn't cancelled: 34 of 34. The six other jobs were all cancelled.
When the live suites run, they still set how long required checks take:
Live / Dockeron Linux AMD64 has a median of 810 s and a maximum of 1,524 s. Follow-up changes will cache Docker layers between runs and reuse the test executablesBuild and testalready compiles.Validation
actionlintpasses onnative-platform.ymlandrust.yml.cargo cipassed: 1,326 workspace tests and 128 lifecycle tests.native-platform.yml.