Attack Defend gamemode#1971
Open
NotHosomi wants to merge 9 commits into
Open
Conversation
blaberry
reviewed
May 22, 2026
blaberry
left a comment
blaberry
left a comment
Collaborator
There was a problem hiding this comment.
Just a question about the attacking/defending neorules implementation
AdamTadeusz
approved these changes
May 29, 2026
AdamTadeusz
reviewed
May 30, 2026
|
|
||
| float GetRoundRemainingTime() const; | ||
| float GetCTGOverTime() const; | ||
| float GetOverTime(NeoGameType eGameType) const; |
Contributor
There was a problem hiding this comment.
why pass eGameType here, maybe read m_nGameTypeSelected same as GetRoundRemainingTime?
Contributor
There was a problem hiding this comment.
I wouldn't worry about it ill refactor this a bit anyway once its merged
Author
There was a problem hiding this comment.
why pass eGameType here, maybe read m_nGameTypeSelected same as GetRoundRemainingTime?
Following the pattern of the code that was in that block of Think originally, where it used a local var that had the current gamemode instead of the member. I think this may also be called in a second place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the Attack/Defend gamemode
Non-parity: included cvars for atk overtime. Only the attacking team recieves overtime
Toolchain
Linked Issues