Bots loot weapons they could not select on spawn due to class restrictions#1997
Bots loot weapons they could not select on spawn due to class restrictions#1997sunzenshen wants to merge 2 commits into
Conversation
| corporal "jittescoped" | ||
| sergeant "zr68c" | ||
| lieutenant "supa7" | ||
| loot "zr68s mx mx_silenced aa13" |
There was a problem hiding this comment.
I initially considered allowing the specification of relative class-exclusive weapon preferences by ranking, but having that level of control turned out to be both messy, and in my opinion not that useful.
One can see the prototype for the rank-specific preference here in this earlier commit:
66f7eaf
It seems easier to just assume that any class-exclusive looting preferences should apply to the LT level, mostly because when I tried to come up with initial configurations I ended up putting most preferences at the LT level anyway.
There was a problem hiding this comment.
Also for reference, since I needed to consider whether selections would have been redundant and already possible with #1800, these are the weapons that each class can never select even if they were LT rank:
Recon:
- ZR suppressed
- MX
- MX suppressed
- SRS
- AA13
Assault:
- SRM suppressed
- Jitte suppressed
- ZR68 scoped
- PZ
Support:
- SRM suppressed
- Jitte suppresed
- ZR suppressed
- ZR scoped
- SRS
- AA13
For testing, the permutations are kind of tricky, but a basic test is to set all bots to Recon with bot_class 0, spawn as an Assault with a ZR suppressed, and throw it at a friendly recon bot. Before with #1800 the bots would not consider the swap.
There was a problem hiding this comment.
Was wondering why it's all tied to LT rank but checking GetBotWeaponPreferenceRank function made sense. So LGTM
There was a problem hiding this comment.
Yeah, I thought maybe bots may want to loot intermediate rank weapons at lower ranks, but in practice I didn't feel that the benefits were worth it for the extra complication of the loot preferences config population code, especially since there's already other options provided by the spawn selection preferences.
| const int idxLieutenant = NEO_RANK__TOTAL - 1; | ||
| pProfile->flagsLootWepPrefs[idxClass][idxLieutenant] |= lootFlags; |
There was a problem hiding this comment.
Nit: idxLieutenant -> IDX_LIEUTENANT
There was a problem hiding this comment.
With other coding guidelines that I've worked under, we tended to reserve all caps for just macro definitions, though I have have also heard of capitalizing all constants in some other style guidelines.
In this case, I wanted to keep the naming similar to idxClass since it might be distracting to have them look different like,
[idxClass][IDX_LIEUTENANT]
| corporal "jittescoped" | ||
| sergeant "zr68c" | ||
| lieutenant "supa7" | ||
| loot "zr68s mx mx_silenced aa13" |
There was a problem hiding this comment.
Was wondering why it's all tied to LT rank but checking GetBotWeaponPreferenceRank function made sense. So LGTM
2 participants
Description
Introduces a configuration for bots to loot weapons that they could not select on spawn due to class restrictions.
Toolchain
Linked Issues