anki: remove uv.lock, use nixpkgs versions of python deps - #498788
Merged
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
dotlambda
reviewed
Mar 11, 2026
dotlambda
left a comment
dotlambda
left a comment
Member
There was a problem hiding this comment.
Thank you very much!
I wonder if we can build the structure inside pyenv using symlinks rather than having uv do so from wheels.
See NixOS#498089, the hack that was previously introduced for using upstream's python package versions isn't acceptable in nixpkgs. Things seem to work from just running anki with this and clicking around; if there's more subtle breakages, we'll have to play whackamole with nixpkgs versions. This also deletes the `update.sh` script, since that will end up having to be shaped somewhat differently after this change. It seems pragmatic to add it back as a followup.
Member
Author
This is more difficult I think. The anki build code expects to write to that directory, and it also invokes Basically, we're populating uv's cache so that anki's build tool can then successfully invoke uv. iirc it's this code, though it could also be being run somewhere else in |
dotlambda
approved these changes
Mar 13, 2026
dotlambda
left a comment
dotlambda
left a comment
Member
There was a problem hiding this comment.
This is a strict improvement, even though we should try to avoid using uv completely.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #498089, the hack that was previously introduced for using upstream's python package versions isn't acceptable in nixpkgs.
Things seem to work from just running anki with this and clicking around; if there's more subtle breakages, we'll have to play whackamole with nixpkgs versions.
This also deletes the
update.shscript, since that will end up having to be shaped somewhat differently after this change. It seems pragmatic to add it back as a followup.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.