detect/ldap: add BindRequest keywords - #16098
0x-0ddc0de wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16098 +/- ##
==========================================
- Coverage 83.05% 83.02% -0.03%
==========================================
Files 1004 1004
Lines 277359 277560 +201
==========================================
+ Hits 230370 230458 +88
- Misses 46989 47102 +113
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
victorjulien
left a comment
There was a problem hiding this comment.
I think this is looking pretty good. Ticket reference needs to go into the commit message as:
Ticket: #7536.
Can you rebase and add that?
615d192 to
21f9747
Compare
Done |
|
Replaced by #16183 |
|
Closing this pull request: its branch was updated after the pull Per our workflow, a new pull request is required when changes are made If you wish to create an in progress pull request that you can push to, Please see our GitHub Pull Request Workflow. |
Implements Redmine #7536.
Adds LDAP BindRequest detection support for:
Also adds documentation for the new keywords.
The corresponding suricata-verify tests are in PR 3311
Redmine: https://redmine.openinfosecfoundation.org/issues/7536
SV_BRANCH=OISF/suricata-verify#3311