detect/ldap: add BindRequest keywords - #16183
Closed
0x-0ddc0de wants to merge 1 commit into
Closed
0x-0ddc0de wants to merge 1 commit into
0x-0ddc0de wants to merge 1 commit into
Conversation
jufajardini
approved these changes
Sep 6, 2026
jufajardini
left a comment
jufajardini
left a comment
Contributor
There was a problem hiding this comment.
Based on the previous PR's request, I'd say this one looks good!
Contributor
|
I think it could be improved with adding these new keywords into etc/schema.json |
catenacyber
reviewed
Sep 16, 2026
| #[repr(u8)] | ||
| pub enum BindAuthenticationChoice { | ||
| Simple = 0, | ||
| Sasl = 1, |
Contributor
There was a problem hiding this comment.
Should be 3 see https://www.rfc-editor.org/info/rfc4511/#section-4.2
Author
added |
Author
|
superceded by #16218 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR. This PR amends the commit message (no code changes).
The corresponding suricata-verify tests are in PR 3354.
Redmine: https://redmine.openinfosecfoundation.org/issues/7536
SV_BRANCH=OISF/suricata-verify#3357