Repository navigation
Conversation
read_buffer_bytes takes a NoGc scope since PerryTS#12103, so the fixture no longer compiled, and the warnings and check jobs stopped there. The fixture's tests also call runtime-backed perry-ffi functions, so they take perry-ffi with runtime-link as a dev-dependency, like the ext crates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V5MSmMLJm6sMdSS5r64ds7
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge in this order:
Problem
CI on
mainis red again after #12025. Commits since then brokecheck,warnings,cargo-test,gc-call-effects,self-test-checkers,gap-suiteand fourteenlintsteps, so no PR can show a green build. Each later failure in a job was hidden behind an earlier one.Solution
Fix each breakage in its own PR. Each PR targets
mainand holds every fix above it in the order list, so the last PR is the one that can run fully green. Merge in order: each diff then shrinks to its own fix.In this PR
Fixes the compile error that stops
checkandwarnings.read_buffer_bytestakes aNoGcscope since #12103, and the docs fixture still called it with one argument.Changes
Read the buffer inside
no_gc(diff). The fixture only needs the length, so it reads it inside the scope.perry/docs/examples/_fixtures/native-libraries/my-bindings/src/lib.rs
Lines 21 to 23 in f93cdd9
Link the runtime for the fixture's tests (diff). Its tests call runtime-backed
perry-ffifunctions. They takeperry-ffiwithruntime-linkas a dev-dependency, as the ext crates do.perry/docs/examples/_fixtures/native-libraries/my-bindings/Cargo.toml
Lines 17 to 19 in f93cdd9
🤖 Generated with Claude Code
https://claude.ai/code/session_01V5MSmMLJm6sMdSS5r64ds7