Repository navigation
Conversation
read_buffer_bytes takes a NoGc scope since PerryTS#12103, so the fixture no longer compiled, and the warnings and check jobs stopped there. The fixture's tests also call runtime-backed perry-ffi functions, so they take perry-ffi with runtime-link as a dev-dependency, like the ext crates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V5MSmMLJm6sMdSS5r64ds7
The runtime does not export the shadow-stack entry points on native stack-map targets. The http, net, streams and ws test modules called them, so they no longer compiled and the warnings job failed. On those targets the guards' shadow frames rooted nothing. The net and http tests now hold the values that must survive a collection in a RuntimeHandleScope. The guards call gc_init(), which registers the runtime-handle scanner that program startup would register. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V5MSmMLJm6sMdSS5r64ds7
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V5MSmMLJm6sMdSS5r64ds7
This was referenced Oct 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge in this order:
Problem
CI on
mainis red again after #12025. Commits since then brokecheck,warnings,cargo-test,gc-call-effects,self-test-checkers,gap-suiteand fourteenlintsteps, so no PR can show a green build. Each later failure in a job was hidden behind an earlier one.Solution
Fix each breakage in its own PR. Each PR targets
mainand holds every fix above it in the order list, so the last PR is the one that can run fully green. Merge in order: each diff then shrinks to its own fix.In this PR
Fixes the rest of
warnings. Since 9af2d89 the runtime exports no shadow-stack entry points on native stack-map targets (64-bit apple, linux, windows). The http, net, streams and ws test modules still called them.Changes
Drop the guards' shadow frames (diff). On these targets the frame rooted nothing. The same change applies to the http, net and streams guards.
Root the values that must survive a collection (diff). The net and http tests hold them in a
RuntimeHandleScope. The guards callgc_init(), which registers the runtime-handle scanner that program startup would register.perry/crates/perry-ext-net/src/tests.rs
Line 9 in ee6659c
🤖 Generated with Claude Code
https://claude.ai/code/session_01V5MSmMLJm6sMdSS5r64ds7