Skip to content

Localize pairing and connection flows in Simplified and Traditional Chinese - #238

Draft
Wangnov wants to merge 3 commits into
Saffsanity:mainfrom
Wangnov:feat/i18n
Draft

Wangnov wants to merge 3 commits into
Saffsanity:mainfrom
Wangnov:feat/i18n

Conversation

@Wangnov

@Wangnov Wangnov commented Oct 27, 2026 •

Copy link
Copy Markdown

Coordination update (2026-11-06): keeping this PR as a draft while #308 provides the broader Simplified Chinese catalog work. The independent connection/pairing state fixes have been extracted into #317. The Traditional Chinese translations remain here and can be adapted to #308 after it lands; this draft is not intended as a competing catalog implementation.

Pairing and connecting currently remain in English on Chinese-language devices. This adds app-owned String Catalogs for English, Simplified Chinese (zh-Hans), and Traditional Chinese (zh-Hant), covering the Mac pairing window, Devices settings, permission guidance and menu entry points, plus the iOS connection, pairing and scanning flows. Related to #237.

Dynamic names and plural forms use native localization. Connection-screen presentation identity is separated from displayed text; protocol identifiers, host-provided unknown/update messages, device names and user-created group names keep their existing meaning. The existing SwiftPM packaging flow is retained, with explicit catalog compilation and a CI check of the assembled Mac app. A compiler-based synchronization command and translation notes are included.

This is an initial localization slice: streaming controls and the remaining settings copy are not fully translated. The fork's Xcode app migration and shared-device-store refactor are deliberately outside this PR.

Validation:

  • All 55 existing pure-check suites passed; no mutation-test runs were added.
  • Mac SwiftPM build and actual ad-hoc app packaging passed; existing app previews were rendered in all three languages.
  • iOS Debug and Release arm64 simulator-target builds passed.
  • Actual app resources were checked for both Chinese variants, permission descriptions, dynamic values, English fallback and plural forms; catalog synchronization was repeatable.

Keeping this as a draft pending iOS UI/device validation and translation review. A zh-Hant terminology review would be welcome; the current translations use Taiwanese terminology.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant