Skip to content

Keep connection and pairing state independent of localized text - #317

Open
Wangnov wants to merge 1 commit into
Saffsanity:mainfrom
Wangnov:fix/i18n-status-identity
Open

Wangnov wants to merge 1 commit into
Saffsanity:mainfrom
Wangnov:fix/i18n-status-identity

Conversation

@Wangnov

@Wangnov Wangnov commented Nov 6, 2026

Copy link
Copy Markdown

The connect screen recognizes discovery and pairing lines, pending overlay requests, and update notices by comparing displayed text. This couples behavior to the wording and can mistake a Mac's reply for a locally generated status.

This extracts the state-handling portion of draft #238 into six iOS files: explicit status kinds keep discovery refreshes and pairing cancellation attached to their own status, pending overlay requests stay silent, and an update link is cleared by the next status assignment. No catalogs, translations, protocol strings, or build configuration change. It complements #308's native String Catalog work; the patch also applies cleanly to its current head (2533106).

Validation:

  • iOS Debug arm64 generic-simulator build passed with Xcode 27.2.
  • git diff --check and patch application to Localize both apps into Simplified Chinese #308 passed.
  • Simulator UI and VoiceOver were not run: the installed CoreSimulator service is older than the selected Xcode build (1174.9.2 versus 1174.21.0).

AI-assisted implementation and review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant