Repository navigation
Conversation
The host half of Saffsanity#156 (dr-apple), unchanged, for Immersive on the iPad; if mode (a second tap on Desktop) is not taken: Immersive asks for the display instead. The device's viewport says so (Viewport.deviceDesktop, optional; an older host ignores it and the Mac's own screen fills the picture). The host then makes a virtual display of the device's size (÷ Aa's scale, at 2x) and makes it the main display while the Desktop streams, as Screen Sharing's High Performance mode does: menu bar and Dock move there, and the device shows a whole Mac desktop edge to edge at its own resolution (DeviceDesktop.swift). A rotation or an Aa step makes it again; anything else streaming, the flag off, the last device leaving or Quit gives the main role back and removes it. The catalog never takes one of Sill's virtual displays for the real screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… own size With Hide Top Bar on, the device sideways and the Desktop streaming, the viewport sets deviceDesktop, so the Mac makes a display of the device's size (DeviceDesktop, the commit before) and the Desktop fills the screen with no letterbox. An overlay that brings the bar back keeps the last full-screen size, so the Mac does not recreate its display for a drawer or a Settings visit. TopBarVisibility.wantsDeviceDesktop and .viewportSize, with checks and mutants B6-B10 in Tests/checks/phone-portrait.
This was referenced Nov 5, 2026
dr-apple
added a commit
to dr-apple/sill
that referenced
this pull request
Nov 6, 2026
Conflicts: - StreamCoordinator: the Desktop's capture moved into desktopCapture(). It takes the device's own display (on:), as Saffsanity#312 resolves it, and the one more try after a failed start passes it too while it lives, so capture and input stay on one display. - StreamScreen, PortraitStreamScreen: both sides kept (the caret note and the pinch zoom beside the full-screen mode). The full-screen picture follows the layouts' since main: ZoomedStreamView and the zoom, the Mac's key repeat for a hardware keyboard, the locked Mac's cover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Desktop edge to edge under Hide Top Bar. Replaces #161 and builds on #197 (#92's decision).
What it does
deviceDesktop. The Mac makes a display of the device's own size for it, so on a 4:3 iPad the Desktop fills the screen instead of letterboxing the Mac's 16:9 screen.hideTopBarHeld.TopBarVisibility.wantsDeviceDesktopand.viewportSize, both pure.DeviceDesktop, theStreamCoordinatorandWindowCatalogchanges, andViewport.deviceDesktop, which is optional and additive.StreamCoordinator, because the Desktop's capture had moved intodesktopCapture(). I resolved it by givingdesktopCapturean optional display (on:). The device display goes through it, and everything else is as on main, including theCatalogLookline, which only applies to the Mac's own display.Checks
Tests/checks/phone-portrait/run.sh: 494 passed, including 6 new checks, one of them 5,000 random sequences of switch, rotation, source and overlay. Mutants: 83 of 83 caught, including the new B6 to B10.protocol: ALL PASS.compatibility: 151 checks, 0 failed.swift buildbuilds the host, with only the known CaptureProbe warning. The iOS simulator build succeeds.Not yet tested