Repository navigation
Conversation
This was referenced Oct 29, 2026
This was referenced Nov 5, 2026
|
Nice one, this matches #92's decision exactly. I've built the Desktop edge to edge on top of it in #312. One thing I noticed while doing that: when an overlay brings the bar back, the bar takes room in the VStack, so the panel shrinks and a new viewport goes to the Mac. For a window that's a refit each time the drawer or Settings opens. Overlaying the bar in a ZStack over the picture would keep the panel's size steady. Not a blocker, just a thought. |
|
merge it brother! :D |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92.
What it does
Sill.hideTopBar, off by default) in Settings › This iPad / This iPhone (HostSettingsPanel).TopBarVisibility.barHidden) and nothing is open over the stream, hidesTopBarso the stream pane fills the full height (and sends the taller viewport to the Mac). Holds the bar visible while Settings is open (hideTopBarHeld) so the panel never moves under the finger.UIWindow.motionEnded(.motionShake)→TopBarVisibility.afterShake) turnsHide Top Baroff, brings the top bar back, and announces"Top bar shown"for VoiceOver.Show Top Bar, shortcut⇧⌘B) while the bar is hidden so docked iPad and accessibility users can restore the bar without shaking.TopBarVisibility(iOSClient/PhonePortraitLayout.swift, pureCoreGraphics+Foundation) with 4 checks and 5 mutants (B1–B5) inTests/checks/phone-portrait.Why
⇧⌘B) to bring the bar back (Feature Request: Hide and show the top window bar #92).Checks
Tests/checks/phone-portrait/run.sh: 488 checks passed (78 of 78 mutants caught).Tests/checks/tour/run.sh: 111,189 checks passed..build/local27.sh: iOS simulator build clean.