Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 5ad1b3d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Mount behavior and regression test packages/svelte-virtual/src/index.ts, packages/svelte-virtual/tests/index.test.ts, .changeset/quick-lists-return.md |
The mount callback applies empty partial options instead of initial options. The test verifies that the updated count and replacement onChange callback remain in effect after resubscription. The changeset records a patch release. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix · Severity of issue fixed: Medium
Suggested reviewers: yeungkc
Merge Risk: 
5ad1b
-
The change preserves updated virtualizer options after resubscription, with regression coverage for size and callback behavior. It is ready to merge subject to normal checks.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: preserving updated options when a Svelte virtualizer store is resubscribed. Description check The description includes the required Changes, Checklist, and Release Impact sections. It explains the motivation, testing, changeset, and linked issue. Linked Issues check Issue #1355requires a Svelte virtualizer store to retain updated options after its last subscriber unsubscribes and a subscriber returns. Inpackages/svelte-virtual/src/index.ts, the mount callback…Out of Scope Changes check The reviewed changes stay within issue #1355. The source change fixes option retention during store resubscription. The tests cover the regression and related callback behavior. The changeset document…Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Full details: Linked Issues check
-
Explanation
Issue
#1355requires a Svelte virtualizer store to retain updated options after its last subscriber unsubscribes and a subscriber returns. Inpackages/svelte-virtual/src/index.ts, the mount callback now callssetOptions({}), which resolves the currentvirtualizer.optionsand currentonChangeinstead of replayinginitialOptions. The added test covers bothcreateVirtualizerandcreateWindowVirtualizer. It verifies the updated count, total size, and replacement callback after resubscription. It also verifies that the old callback does not run and that the subscriber receives the update.
Full details: Out of Scope Changes check
-
Explanation
The reviewed changes stay within issue
#1355. The source change fixes option retention during store resubscription. The tests cover the regression and related callback behavior. The changeset documents the published Svelte package fix. No unrelated change is shown in the supplied change summary or reviewed files.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
|
View your CI Pipeline Execution ↗ for commit 5ad1b3d
☁️ Nx Cloud last updated this comment at |
|
Thanks @clean99! |
Changes
resolves #1355
Resubscribing to a virtualizer store currently restores its initial count and callback. Keep the current options when restarting the subscription. The regression test checks the updated total size and that only the current callback runs.
pnpm run test:prpasses, including the Svelte tests, lint, types, build and publint.Checklist
pnpm run test:pr.Release Impact
Summary by CodeRabbit