Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quick-lists-return.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/svelte-virtual': patch
---

Preserve updated virtualizer options when a Svelte store is resubscribed.
2 changes: 1 addition & 1 deletion packages/svelte-virtual/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ function createVirtualizerBase<
}

virtualizerWritable = writable(virtualizer, () => {
setOptions(initialOptions)
setOptions({})
return virtualizer._didMount()
})

Expand Down
33 changes: 33 additions & 0 deletions packages/svelte-virtual/tests/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,39 @@ describe.each([
}
})

test('preserves updated options when the store is resubscribed', () => {
const onChange = vi.fn()
const nextOnChange = vi.fn()
const store = create({
count: 100,
estimateSize: () => 40,
getScrollElement: () => null,
onChange,
})
const unsubscribe = store.subscribe(() => {})
const virtualizer = get<TestVirtualizer>(store)
virtualizer.setOptions({ count: 110, onChange: nextOnChange })
unsubscribe()

const subscriber = vi.fn()
const resubscribe = store.subscribe(subscriber)

try {
expect(virtualizer.options.count).toBe(110)
expect(virtualizer.getTotalSize()).toBe(4400)
onChange.mockClear()
nextOnChange.mockClear()
subscriber.mockClear()
virtualizer.measure()

expect(onChange).not.toHaveBeenCalled()
expect(nextOnChange).toHaveBeenCalledExactlyOnceWith(virtualizer, false)
expect(subscriber).toHaveBeenCalledExactlyOnceWith(virtualizer)
} finally {
resubscribe()
}
})

test('updates the store when no onChange was supplied', () => {
const subscriber = vi.fn()
const store = create({
Expand Down
Loading