Skip to content

fix(bench): restore topology construction repair policy - #561

Merged
acgetchell merged 1 commit into
mainfrom
fix/541-topology-benchmark
Aug 15, 2026
Merged

fix(bench): restore topology construction repair policy#561
acgetchell merged 1 commit into
mainfrom
fix/541-topology-benchmark

Conversation

@acgetchell

Copy link
Copy Markdown
Owner
  • Use the default Delaunay repair cadence during construction measurements.
  • Require insertion and completion validation to succeed for every sample.
  • Update the manual suite runtime estimate for the repaired workload.

Fixes #541

- Use the default Delaunay repair cadence during construction measurements.
- Require insertion and completion validation to succeed for every sample.
- Update the manual suite runtime estimate for the repaired workload.

Fixes #541
@acgetchell acgetchell self-assigned this Aug 14, 2026
@acgetchell
acgetchell enabled auto-merge (squash) August 14, 2026 23:02
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 4343b4b2-8cec-4442-b7ff-122ea8cdd8e5

📥 Commits

Reviewing files that changed from the base of the PR and between e7fd9b8 and 4f2dfee.

📒 Files selected for processing (2)
  • benches/README.md
  • benches/topology_guarantee_construction.rs

Walkthrough

The topology-guarantee construction benchmarks now use the default Delaunay repair policy, retain validation, abort on insertion errors, and require completion validation. The benchmark documentation reports a 45–60 minute runtime estimate.

Changes

Topology benchmark updates

Layer / File(s) Summary
Benchmark policy and validation handling
benches/topology_guarantee_construction.rs, benches/README.md
The benchmarks use the default repair policy, simplify insertion failure handling, propagate completion-validation errors with or_abort(), and update the documented runtime estimate.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 4f2df

This change restores benchmark construction validation and updates the documented runtime estimate; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

Suggested labels: bug, rust, topology

Poem

I’m a rabbit in the benchmark run,
Repairing cells beneath the sun.
Errors hop straight to or_abort(),
Validation guards each plot.
Forty-five to sixty minutes—
Reliable hops from start to finish.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies restoring the repair policy for the topology construction benchmark.
Description check ✅ Passed The description accurately summarizes the repair policy, validation, error handling, and runtime documentation changes.
Linked Issues check ✅ Passed The changes restore default repair, retain validation, require successful insertion and completion checks, and preserve the manual benchmark scope.
Out of Scope Changes check ✅ Passed The code and documentation changes are limited to the linked issue objectives and contain no unrelated scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/541-topology-benchmark

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added bug Something isn't working rust Pull requests that update rust code topology labels Aug 14, 2026
@codacy-production

codacy-production Bot commented Aug 14, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation +0.00% coverage variation (-1.00%)
Diff coverage diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e7fd9b8) 82353 75551 91.74%
Head commit (4f2dfee) 82353 (+0) 75551 (+0) 91.74% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#561) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.72%. Comparing base (e7fd9b8) to head (4f2dfee).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          88       88           
  Lines       82142    82142           
=======================================
  Hits        75342    75342           
  Misses       6800     6800           
Flag Coverage Δ
unittests 91.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@acgetchell
acgetchell merged commit d1d2f7f into main Aug 15, 2026
23 checks passed
@acgetchell
acgetchell deleted the fix/541-topology-benchmark branch August 15, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working rust Pull requests that update rust code topology

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix topology-guarantee construction benchmark repair policy

1 participant