Skip to content

fix(bench): restore topology construction repair policy #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acgetchell merged 1 commit into from
Aug 15, 2026
Merged

fix(bench): restore topology construction repair policy #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benches/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ allocation checks, or targeted diagnostics.
| `delete_vertex.rs` | Vertex deletion and rollback cost | 2D-5D fixed cases | ~1-5 min | Vertex deletion |
| `locate.rs` | Point-location facet-walk latency (no-hint vs exact-hint) | 2D-5D fixed cases | ~1-3 min | Locate/walk tuning |
| `tds_clone.rs` | `Tds::clone()` snapshot cost | Deterministic 2D-5D triangulations | ~1-3 min | Rollback design baselines |
| `topology_guarantee_construction.rs` | Cost of topology guarantee modes | 2D-5D construction cases | ~5-15 min | Manual topology policy work |
| `topology_guarantee_construction.rs` | Cost of topology guarantee modes | 2D-5D construction cases | ~45-60 min | Manual topology policy work |

## Selection Guide

Expand Down
22 changes: 8 additions & 14 deletions benches/topology_guarantee_construction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ use criterion::{BenchmarkId, Criterion, Throughput, criterion_group, criterion_m
use delaunay::prelude::construction::{DelaunayTriangulation, TopologyGuarantee, vertex};
use delaunay::prelude::generators::generate_random_points_in_range_seeded;
use delaunay::prelude::geometry::CoordinateRange;
use delaunay::prelude::repair::DelaunayRepairPolicy;
use delaunay::prelude::validation::ValidationPolicy;
use std::hint::black_box;
use std::time::Duration;
Expand Down Expand Up @@ -69,20 +68,17 @@ fn bench_dimension<const D: usize>(
TopologyGuarantee::Pseudomanifold,
);

// Exercise topology validation cost under each guarantee and disable
// flip-based Delaunay repair for consistent comparison.
// Exercise topology validation cost under each guarantee while retaining
// the production repair policy so every measured result stays valid.
dt.set_validation_policy(ValidationPolicy::Always);
dt.set_delaunay_repair_policy(DelaunayRepairPolicy::Never);

for v in vertices {
// Use the statistics API so retryable degeneracies can be skipped
// (transactional rollback) instead of aborting the benchmark.
if let Err(error) = dt.insert_with_statistics(*v) {
abort_benchmark(format_args!("non-retryable insertion error: {error}"));
abort_benchmark(format_args!("insertion error: {error}"));
}
}
// Completion-time PL-manifold certification when required.
let _ = dt.as_triangulation().validate_at_completion();
dt.as_triangulation().validate_at_completion().or_abort();

black_box(dt)
});
Expand All @@ -100,16 +96,15 @@ fn bench_dimension<const D: usize>(
);

dt.set_validation_policy(ValidationPolicy::Always);
dt.set_delaunay_repair_policy(DelaunayRepairPolicy::Never);

for v in vertices {
if let Err(error) = dt.insert_with_statistics(*v) {
abort_benchmark(format_args!("non-retryable insertion error: {error}"));
abort_benchmark(format_args!("insertion error: {error}"));
}
}

// Completion-time PL-manifold certification when required.
let _ = dt.as_triangulation().validate_at_completion();
dt.as_triangulation().validate_at_completion().or_abort();

black_box(dt)
});
Expand All @@ -127,15 +122,14 @@ fn bench_dimension<const D: usize>(
);

dt.set_validation_policy(ValidationPolicy::Always);
dt.set_delaunay_repair_policy(DelaunayRepairPolicy::Never);

for v in vertices {
if let Err(error) = dt.insert_with_statistics(*v) {
abort_benchmark(format_args!("non-retryable insertion error: {error}"));
abort_benchmark(format_args!("insertion error: {error}"));
}
}
// Completion-time PL-manifold certification when required.
let _ = dt.as_triangulation().validate_at_completion();
dt.as_triangulation().validate_at_completion().or_abort();

black_box(dt)
});
Expand Down
Loading