feat(mermaid): add SlotsType declaration for header and custom action slots#107
Merged
Conversation
… slots Mermaid already supports the `header`, `customActionIconRender` and `customActionRender` slots at runtime, but they were untyped (no static checking or IDE completion). Declare a `MermaidSlots` interface via `SlotsType` and export it, so slot usage is type-checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
Mermaidalready supportsheader,customActionIconRender, andcustomActionRenderslots at runtime, but the slot types were not declared explicitly. This means consumers can use the slots, but there was no static typing or IDE completion.This PR adds a
MermaidSlotsinterface and wires it intodefineComponentwithSlotsType<MermaidSlots>, then exports the slot type from the package entry.📝 Change Log
Mermaidnow declares typed slots forheader,customActionIconRender, andcustomActionRenderviaSlotsType, improving type safety and IDE completion.Mermaid现在通过SlotsType显式声明了header、customActionIconRender和customActionRender插槽，提升类型安全和 IDE 补全。