Repository navigation
[Python] Fix __int__ typo and join_fn type hints in Milvus search handler - #40475
Merged
Abacn merged 1 commit intoOct 9, 2026
Merged
Conversation
…dler Remove the stray MilvusBaseRanker.__int__ (a typo for __init__ that made int(ranker) raise TypeError, and the base class has no state to initialize), and annotate join_fn with EmbeddableItem, which is what the handler actually passes in, instead of Embedding. Fixes apache#40474 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
1 of 17 tasks
Contributor
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
shunping
approved these changes
Oct 9, 2026
shunping
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for filing the bug and fix it right away! LGTM and waiting for the tests to finish before merging.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40475 +/- ##
============================================
+ Coverage 56.16% 56.23% +0.06%
Complexity 2288 2288
============================================
Files 1124 1124
Lines 178336 178359 +23
Branches 1489 1489
============================================
+ Hits 100170 100303 +133
+ Misses 75645 75535 -110
Partials 2521 2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the stray
MilvusBaseRanker.__int__, a typo for__init__that madeint(ranker)raiseTypeError; the base class has no state to initialize, so it is removed rather than renamed. Also annotatesjoin_fnwithEmbeddableItem, which the handler actually passes in, instead ofEmbedding, and drops the now-unusedEmbeddingimport.No behavior change for existing users. Existing unit tests pass.
Fixes #40474